[GitHub] [pinot] Jackie-Jiang commented on pull request #10139: JMX to Prom Exporter - More Inclusive Table Regex

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on PR #10139:
URL: https://github.com/apache/pinot/pull/10139#issuecomment-1396204741

   Good catch!
   Table name can actually contain spaces, so we can probably just match any character.
   There are other regex that do not contain the table type, which should also be modified.
   When the table name contains `_`, can it correctly match the name? If not, we should consider changing the table type matching to only match `OFFLINE` and `REALTIME`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org