You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/13 03:36:51 UTC
[GitHub] [incubator-nuttx-apps] liuguo09 opened a new pull request #120:
examples/posix_spawn: Fix parallel build errors at link time
liuguo09 opened a new pull request #120: examples/posix_spawn: Fix parallel build errors at link time
URL: https://github.com/apache/incubator-nuttx-apps/pull/120
During generating symtab.c, compile seqeuence would start with
incomplete symtab.c. This change will fix such a situation.
Signed-off-by: liuhaitao <li...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] liuguo09 commented on issue #120:
examples/posix_spawn: Fix parallel build errors at link time
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #120: examples/posix_spawn: Fix parallel build errors at link time
URL: https://github.com/apache/incubator-nuttx-apps/pull/120#issuecomment-598533095
@masayuki2009 I apply your elf change to posix_spawn since same problem occurred.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 edited a comment on issue #120:
examples/posix_spawn: Fix parallel build errors at link time
Posted by GitBox <gi...@apache.org>.
masayuki2009 edited a comment on issue #120: examples/posix_spawn: Fix parallel build errors at link time
URL: https://github.com/apache/incubator-nuttx-apps/pull/120#issuecomment-598534432
> @masayuki2009 I apply your elf change to posix_spawn since same problem occurred.
@liuguo09 Thanks, I thought I should apply the same change to posix_spawn after the new nightly build completes to check if my approach https://github.com/apache/incubator-nuttx-apps/pull/118 was correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 merged pull request #120:
examples/posix_spawn: Fix parallel build errors at link time
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #120: examples/posix_spawn: Fix parallel build errors at link time
URL: https://github.com/apache/incubator-nuttx-apps/pull/120
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #120:
examples/posix_spawn: Fix parallel build errors at link time
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #120: examples/posix_spawn: Fix parallel build errors at link time
URL: https://github.com/apache/incubator-nuttx-apps/pull/120#issuecomment-598534432
> @masayuki2009 I apply your elf change to posix_spawn since same problem occurred.
@liuguo09 Thanks, I thought I should apply the same change to posix_spawn after the new nightly build completes to check if my approach was correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #120:
examples/posix_spawn: Fix parallel build errors at link time
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #120: examples/posix_spawn: Fix parallel build errors at link time
URL: https://github.com/apache/incubator-nuttx-apps/pull/120#issuecomment-600904989
I confirmed that this PR would be effective.
See https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-600904711.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 edited a comment on issue #120:
examples/posix_spawn: Fix parallel build errors at link time
Posted by GitBox <gi...@apache.org>.
masayuki2009 edited a comment on issue #120: examples/posix_spawn: Fix parallel build errors at link time
URL: https://github.com/apache/incubator-nuttx-apps/pull/120#issuecomment-600904989
I confirmed that this PR would be effective.
See https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-600904711.
So let's try to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #120:
examples/posix_spawn: Fix parallel build errors at link time
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #120: examples/posix_spawn: Fix parallel build errors at link time
URL: https://github.com/apache/incubator-nuttx-apps/pull/120#issuecomment-599288371
According to comments in #118 from @liuguo09
>You are right. It seems the mv operation to symtab.c reduces the probability
>of build break(from my local build, it is easy to hit the link error without mv operation),
>but it doesn't root cause the link errors in the latest nightly build.
Thanks for the comment, though I think we have another root cause of the link errors in nightly build. This PR might reduce the probability as well. So let's merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #120:
examples/posix_spawn: Fix parallel build errors at link time
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #120: examples/posix_spawn: Fix parallel build errors at link time
URL: https://github.com/apache/incubator-nuttx-apps/pull/120#issuecomment-599941501
> According to comments in #118 from @liuguo09
>
> > You are right. It seems the mv operation to symtab.c reduces the probability
> > of build break(from my local build, it is easy to hit the link error without mv operation),
> > but it doesn't root cause the link errors in the latest nightly build.
>
> Thanks for the comment, though I think we have another root cause of the link errors in nightly build. This PR might reduce the probability as well. So let's merge this PR.
Another try:
https://github.com/apache/incubator-nuttx-apps/pull/123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services