You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bo...@apache.org on 2021/09/25 11:34:42 UTC
[ant] branch master updated: Change StringBuffer in favor of
StringBuilder.
This is an automated email from the ASF dual-hosted git repository.
bodewig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ant.git
The following commit(s) were added to refs/heads/master by this push:
new 8a402ee Change StringBuffer in favor of StringBuilder.
new 28b9927 Merge pull request #154 from arturobernalg/feature/string_builder
8a402ee is described below
commit 8a402eea3a2a040ac760a2638ab15b3f2baf81ef
Author: Arturo Bernal <ar...@gmail.com>
AuthorDate: Tue Aug 31 20:50:31 2021 +0200
Change StringBuffer in favor of StringBuilder.
---
src/main/org/apache/tools/ant/filters/BaseFilterReader.java | 2 +-
src/main/org/apache/tools/ant/filters/TokenFilter.java | 4 ++--
src/main/org/apache/tools/ant/taskdefs/KeySubst.java | 2 +-
src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java | 2 +-
src/main/org/apache/tools/ant/taskdefs/Redirector.java | 2 +-
src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java | 2 +-
src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java | 2 +-
src/main/org/apache/tools/ant/util/FileUtils.java | 2 +-
8 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/main/org/apache/tools/ant/filters/BaseFilterReader.java b/src/main/org/apache/tools/ant/filters/BaseFilterReader.java
index fdb6416..bc97d1b 100644
--- a/src/main/org/apache/tools/ant/filters/BaseFilterReader.java
+++ b/src/main/org/apache/tools/ant/filters/BaseFilterReader.java
@@ -173,7 +173,7 @@ public abstract class BaseFilterReader extends FilterReader {
return null;
}
- StringBuffer line = new StringBuffer();
+ final StringBuilder line = new StringBuilder();
while (ch != -1) {
line.append((char) ch);
diff --git a/src/main/org/apache/tools/ant/filters/TokenFilter.java b/src/main/org/apache/tools/ant/filters/TokenFilter.java
index 441cf9d..67c9283 100644
--- a/src/main/org/apache/tools/ant/filters/TokenFilter.java
+++ b/src/main/org/apache/tools/ant/filters/TokenFilter.java
@@ -370,7 +370,7 @@ public class TokenFilter extends BaseFilterReader
if (from == null) {
throw new BuildException("Missing from in stringreplace");
}
- StringBuffer ret = new StringBuffer();
+ final StringBuilder ret = new StringBuilder();
int start = 0;
int found = line.indexOf(from);
while (found >= 0) {
@@ -620,7 +620,7 @@ public class TokenFilter extends BaseFilterReader
* @return the converted string
*/
public String filter(String string) {
- StringBuffer output = new StringBuffer(string.length());
+ StringBuilder output = new StringBuilder(string.length());
for (int i = 0; i < string.length(); ++i) {
char ch = string.charAt(i);
if (!(isDeleteCharacter(ch))) {
diff --git a/src/main/org/apache/tools/ant/taskdefs/KeySubst.java b/src/main/org/apache/tools/ant/taskdefs/KeySubst.java
index 6424868..a6961bd 100644
--- a/src/main/org/apache/tools/ant/taskdefs/KeySubst.java
+++ b/src/main/org/apache/tools/ant/taskdefs/KeySubst.java
@@ -167,7 +167,7 @@ public class KeySubst extends Task {
*/
public static String replace(String origString, Hashtable<String, String> keys)
throws BuildException {
- StringBuffer finalString = new StringBuffer();
+ final StringBuilder finalString = new StringBuilder();
int index = 0;
int i = 0;
String key = null;
diff --git a/src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java b/src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java
index 62237ef..d6b3f6f 100644
--- a/src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java
+++ b/src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java
@@ -188,7 +188,7 @@ public class RecorderEntry implements BuildLogger, SubBuildListener {
public void messageLogged(BuildEvent event) {
log("--- MESSAGE LOGGED", Project.MSG_DEBUG);
- StringBuffer buf = new StringBuffer();
+ final StringBuilder buf = new StringBuilder();
if (event.getTask() != null) {
String name = event.getTask().getTaskName();
diff --git a/src/main/org/apache/tools/ant/taskdefs/Redirector.java b/src/main/org/apache/tools/ant/taskdefs/Redirector.java
index 9950e9a..2ca7bd0 100644
--- a/src/main/org/apache/tools/ant/taskdefs/Redirector.java
+++ b/src/main/org/apache/tools/ant/taskdefs/Redirector.java
@@ -704,7 +704,7 @@ public class Redirector {
}
((ConcatFileInputStream) inputStream).setManagingComponent(managingTask);
} else if (inputString != null) {
- final StringBuffer buf = new StringBuffer("Using input ");
+ final StringBuilder buf = new StringBuilder("Using input ");
if (logInputString) {
buf.append('"').append(inputString).append('"');
} else {
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java b/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java
index 5b71ae5..1be941c 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java
@@ -550,7 +550,7 @@ public class TraXLiaison implements XSLTLiaison4, ErrorListener, XSLTLoggerAware
return;
}
- final StringBuffer msg = new StringBuffer();
+ final StringBuilder msg = new StringBuilder();
final SourceLocator locator = e.getLocator();
if (locator != null) {
final String systemid = locator.getSystemId();
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java b/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java
index c174b34..6448604 100644
--- a/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java
+++ b/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java
@@ -745,7 +745,7 @@ public abstract class MSVSS extends Task implements MSVSSConstants {
* @return The command line as a string with out the password
*/
private String formatCommandLine(Commandline cmd) {
- StringBuffer sBuff = new StringBuffer(cmd.toString());
+ final StringBuilder sBuff = new StringBuilder(cmd.toString());
int indexUser = sBuff.substring(0).indexOf(FLAG_LOGIN);
if (indexUser > 0) {
int indexPass = sBuff.substring(0).indexOf(",", indexUser);
diff --git a/src/main/org/apache/tools/ant/util/FileUtils.java b/src/main/org/apache/tools/ant/util/FileUtils.java
index 52c6625..6a972e0 100644
--- a/src/main/org/apache/tools/ant/util/FileUtils.java
+++ b/src/main/org/apache/tools/ant/util/FileUtils.java
@@ -822,7 +822,7 @@ public class FileUtils {
//remove the initial separator; the root has it.
next = (ca[next] == sep) ? next + 1 : next;
- StringBuffer sbPath = new StringBuffer();
+ final StringBuilder sbPath = new StringBuilder();
// Eliminate consecutive slashes after the drive spec:
for (int i = next; i < ca.length; i++) {
if (ca[i] != sep || ca[i - 1] != sep) {