[GitHub] [skywalking] wankai123 commented on a change in pull request #8419: Add source layer and dest layer to relation

[GitBox <gi...@apache.org>]

wankai123 commented on a change in pull request #8419:
URL: https://github.com/apache/skywalking/pull/8419#discussion_r783142994



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ServiceRelation.java
##########
@@ -61,11 +62,17 @@ public String getEntityId() {
     @Setter
     private String sourceServiceInstanceName;
     @Getter
+    @Setter
+    private Layer sourceLayer;
+    @Getter
     private String destServiceId;
     @Getter
     @Setter
     @ScopeDefaultColumn.DefinedByField(columnName = "dest_name", requireDynamicActive = true)
     private String destServiceName;
+    @Getter
+    @Setter
+    private Layer destLayer;

Review comment:
       Should relation needs layer?  if so the relations here: https://github.com/apache/skywalking/blob/master/oap-server/server-receiver-plugin/skywalking-mesh-receiver-plugin/src/main/java/org/apache/skywalking/aop/server/receiver/mesh/TelemetryDataDispatcher.java
   are needs to set to `Layer.mesh` @wu-sheng




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org