[jira] [Commented] (SQOOP-2606) Sqoop2: Do not reconfigure log4j if there are no log4j properties inside sqoop.properties file

["Sqoop QA bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946016#comment-14946016 ] 

Sqoop QA bot commented on SQOOP-2606:
-------------------------------------

Testing file [SQOOP-2606.patch|https://issues.apache.org/jira/secure/attachment/12765281/SQOOP-2606.patch] against branch sqoop2 took 0:02:49.890222.

{color:red}Overall:{color} -1 due to an error(s), see details below:

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:red}ERROR:{color} Patch does not add/modify any test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:red}ERROR:{color} Some of unit tests failed ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1763/artifact/patch-process/test_unit.txt], executed 0 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1763/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1763/artifact/patch-process/findbugs_report.txt])
{color:red}ERROR:{color} Some of integration tests failed ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1763/artifact/patch-process/test_integration.txt], executed 146 tests)
* Test {{TestSuite}}



Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1763/console].

This message is automatically generated.

> Sqoop2: Do not reconfigure log4j if there are no log4j properties inside sqoop.properties file
> ----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-2606
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2606
>             Project: Sqoop
>          Issue Type: Bug
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2606.patch
>
>
> Current [SqoopConfiguration|https://github.com/apache/sqoop/blob/sqoop2/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java#L283] implementation will assume that log4 is *always* configured inside {{sqoop.properties}} file and if this is not the case, then it will reconfigure log4j with "nothing". I like the ability to specify log4j properties inside the configuration file - that is very handy, however they are valid use cases when one would supply the log4j configuration using "usual" means and hence we should not re-configure log4j if there is no configuration inside the {{sqoop.properties}} file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)