You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by andytaylor <gi...@git.apache.org> on 2017/08/18 09:45:08 UTC
[GitHub] activemq-artemis pull request #1471: ARTEMIS-1350 - Update management consol...
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1471
ARTEMIS-1350 - Update management console to expose client side objects
https://issues.apache.org/jira/browse/ARTEMIS-1350
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andytaylor/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1471.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1471
----
commit 0ea49e8711924ddc141fb004bca0d5ab172fef4d
Author: Andy Taylor <an...@gmail.com>
Date: 2017-08-18T09:43:30Z
ARTEMIS-1350 - Update management console to expose client side objects
https://issues.apache.org/jira/browse/ARTEMIS-1350
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1471: ARTEMIS-1350 - Update management consol...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1471#discussion_r133925691
--- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/html/consumers.html ---
@@ -44,9 +44,30 @@
</button>
</form>
</div>
+
+ <div class="pull-right">
+ <form class="form-inline">
+ <button class="btn-danger" ng-disabled="gridOptions.selectedItems.length == 0"
+ ng-click="deleteDialog = true"
+ title="Close the selected Consumer">
+ <i class="icon-remove"></i> Close
+ </button>
+
+ </form>
+ </div>
</div>
</div>
+ <div hawtio-confirm-dialog="deleteDialog"
+ ok-button-text="Close"
+ on-ok="closeConsumer()">
+ <div class="dialog-body">
+ <p>You are about to close the selected session: {{gridOptions.selectedItems[0].id}}
--- End diff --
should this be
> You are about to close the selected **consumer**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1471: ARTEMIS-1350 - Update management consol...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1471
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1471: ARTEMIS-1350 - Update management consol...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1471#discussion_r133951178
--- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/html/consumers.html ---
@@ -44,9 +44,30 @@
</button>
</form>
</div>
+
+ <div class="pull-right">
+ <form class="form-inline">
+ <button class="btn-danger" ng-disabled="gridOptions.selectedItems.length == 0"
+ ng-click="deleteDialog = true"
+ title="Close the selected Consumer">
+ <i class="icon-remove"></i> Close
+ </button>
+
+ </form>
+ </div>
</div>
</div>
+ <div hawtio-confirm-dialog="deleteDialog"
+ ok-button-text="Close"
+ on-ok="closeConsumer()">
+ <div class="dialog-body">
+ <p>You are about to close the selected session: {{gridOptions.selectedItems[0].id}}
--- End diff --
Actually, the button does seem to be disabled. It just isn't visibly disabled, e.g. greyed out etc... I think this is OK. I have some minor layout fixes and the comment from @michaelandrepearce . I will squash and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1471: ARTEMIS-1350 - Update management consol...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1471#discussion_r133948157
--- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/html/consumers.html ---
@@ -44,9 +44,30 @@
</button>
</form>
</div>
+
+ <div class="pull-right">
+ <form class="form-inline">
+ <button class="btn-danger" ng-disabled="gridOptions.selectedItems.length == 0"
+ ng-click="deleteDialog = true"
+ title="Close the selected Consumer">
+ <i class="icon-remove"></i> Close
+ </button>
+
+ </form>
+ </div>
</div>
</div>
+ <div hawtio-confirm-dialog="deleteDialog"
+ ok-button-text="Close"
+ on-ok="closeConsumer()">
+ <div class="dialog-body">
+ <p>You are about to close the selected session: {{gridOptions.selectedItems[0].id}}
--- End diff --
There are some issues with the layout. The buttons do not disable when nothing select and the submission will try with empty id. I will see if I can fix here, @andytaylor I'll send a PR to your branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1471: ARTEMIS-1350 - Update management consol...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1471#discussion_r133925554
--- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java ---
@@ -773,6 +773,24 @@ void destroyQueue(@Parameter(name = "name", desc = "Name of the queue to destroy
boolean closeConnectionsForUser(@Parameter(desc = "a user name", name = "userName") String address) throws Exception;
/**
+ * Closes the connection with the given id.
+ */
+ @Operation(desc = "Closes all the connection with the id", impact = MBeanOperationInfo.INFO)
+ boolean closeConnectionWithID(@Parameter(desc = "The connection ID", name = "ID") String ID) throws Exception;
+
+ /**
+ * Closes the session with the given id.
+ */
+ @Operation(desc = "Closes the session with the id", impact = MBeanOperationInfo.INFO)
+ boolean closeSessionWithID(String connectionID, String ID) throws Exception;
+
+ /**
+ * Closes the session with the given id.
--- End diff --
nit: java doc should state closes the **consumer**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---