You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pranav Saxena <pr...@citrix.com> on 2012/07/06 20:33:36 UTC
Review Request: CS-15425: Clicking on "About" button - Message refers to
CloudStack instead of CloudPlatform(p1)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5811/
-----------------------------------------------------------
Review request for cloudstack and Brian Federle.
Description
-------
1. Log in as an admin or regular user.
2. On the top right corner of the UI, next to the user name, click on the arrow that is pointed downwards.
3. Click on the "About" Button from the dropdown list.
=================
Expected Test Results:
=================
CloudPlatform name is expected in the message.BUT "cloudstack" is currently displayed.
so wrote a helper function to render the text and a regular expression would parse the rendered text and replace 'cloudstack' with 'cloudPlatform' in case it is a proprietary build.
This addresses bug CS-15425.
Diffs
-----
ui/scripts/ui/core.js a1c58a7
Diff: https://reviews.apache.org/r/5811/diff/
Testing
-------
Verified on my local cloudstack set up.Attached the screenshot after the helpder function was added by me to get the desired output.
Thanks,
Pranav Saxena
Re: Review Request: CS-15425: Clicking on "About" button - Message refers to
CloudStack instead of CloudPlatform(p1)
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5811/#review8926
-----------------------------------------------------------
Unfortunately this is not relevant for the Apache/OSS version, so a review request isn't applicable here.
- Brian Federle
On July 6, 2012, 6:33 p.m., Pranav Saxena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5811/
> -----------------------------------------------------------
>
> (Updated July 6, 2012, 6:33 p.m.)
>
>
> Review request for cloudstack and Brian Federle.
>
>
> Description
> -------
>
> 1. Log in as an admin or regular user.
> 2. On the top right corner of the UI, next to the user name, click on the arrow that is pointed downwards.
> 3. Click on the "About" Button from the dropdown list.
>
> =================
> Expected Test Results:
> =================
>
> CloudPlatform name is expected in the message.BUT "cloudstack" is currently displayed.
>
> so wrote a helper function to render the text and a regular expression would parse the rendered text and replace 'cloudstack' with 'cloudPlatform' in case it is a proprietary build.
>
>
> This addresses bug CS-15425.
>
>
> Diffs
> -----
>
> ui/scripts/ui/core.js a1c58a7
>
> Diff: https://reviews.apache.org/r/5811/diff/
>
>
> Testing
> -------
>
> Verified on my local cloudstack set up.Attached the screenshot after the helpder function was added by me to get the desired output.
>
>
> Thanks,
>
> Pranav Saxena
>
>
Re: Review Request: CS-15425: Clicking on "About" button - Message
refers to CloudStack instead of CloudPlatform(p1)
Posted by David Nalley <da...@gnsa.us>.
On Fri, Jul 6, 2012 at 2:44 PM, Brian Federle <br...@citrix.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5811/
>
> On July 6th, 2012, 6:39 p.m., *David Nalley* wrote:
>
> This is not at all the desired output.
>
> This is Apache CloudStack, and the about should reference "Apache CloudStack"
>
> This bug won't happen on the OSS version ('CloudStack' will always appear in the Apache verison). The modification for this is just to be able to conditionally change the 'About' dialog title so that 'CloudStack' isn't hardcoded, as is the problem reported in the bug.
>
>
So no offense, but that's a problem for Cloudplatform, not for CloudStack.
There is only a single version of Apache CloudStack, and filing
CloudPlatform-specific bugs on the CloudStack bug tracker, against the
CloudStack project is inappropriate.
--David
Re: Review Request: CS-15425: Clicking on "About" button - Message refers to
CloudStack instead of CloudPlatform(p1)
Posted by Brian Federle <br...@citrix.com>.
> On July 6, 2012, 6:39 p.m., David Nalley wrote:
> > This is not at all the desired output.
> >
> > This is Apache CloudStack, and the about should reference "Apache CloudStack"
This bug won't happen on the OSS version ('CloudStack' will always appear in the Apache verison). The modification for this is just to be able to conditionally change the 'About' dialog title so that 'CloudStack' isn't hardcoded, as is the problem reported in the bug.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5811/#review8924
-----------------------------------------------------------
On July 6, 2012, 6:33 p.m., Pranav Saxena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5811/
> -----------------------------------------------------------
>
> (Updated July 6, 2012, 6:33 p.m.)
>
>
> Review request for cloudstack and Brian Federle.
>
>
> Description
> -------
>
> 1. Log in as an admin or regular user.
> 2. On the top right corner of the UI, next to the user name, click on the arrow that is pointed downwards.
> 3. Click on the "About" Button from the dropdown list.
>
> =================
> Expected Test Results:
> =================
>
> CloudPlatform name is expected in the message.BUT "cloudstack" is currently displayed.
>
> so wrote a helper function to render the text and a regular expression would parse the rendered text and replace 'cloudstack' with 'cloudPlatform' in case it is a proprietary build.
>
>
> This addresses bug CS-15425.
>
>
> Diffs
> -----
>
> ui/scripts/ui/core.js a1c58a7
>
> Diff: https://reviews.apache.org/r/5811/diff/
>
>
> Testing
> -------
>
> Verified on my local cloudstack set up.Attached the screenshot after the helpder function was added by me to get the desired output.
>
>
> Thanks,
>
> Pranav Saxena
>
>
RE: Review Request: CS-15425: Clicking on "About" button - Message
refers to CloudStack instead of CloudPlatform(p1)
Posted by Pranav Saxena <pr...@citrix.com>.
The bug ticket says (created by Chandan) - http://bugs.cloudstack.org/browse/CS-15425 that it is supposed to be 'CloudPlatform' . In case it needs to be 'Apache CloudStack' , I can update the patch by changing my regular expression.
Regards,
Pranav
-----Original Message-----
From: David Nalley [mailto:noreply@reviews.apache.org] On Behalf Of David Nalley
Sent: Saturday, July 07, 2012 12:10 AM
To: Brian Federle
Cc: cloudstack; David Nalley; Pranav Saxena
Subject: Re: Review Request: CS-15425: Clicking on "About" button - Message refers to CloudStack instead of CloudPlatform(p1)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5811/#review8924
-----------------------------------------------------------
This is not at all the desired output.
This is Apache CloudStack, and the about should reference "Apache CloudStack"
- David Nalley
On July 6, 2012, 6:33 p.m., Pranav Saxena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5811/
> -----------------------------------------------------------
>
> (Updated July 6, 2012, 6:33 p.m.)
>
>
> Review request for cloudstack and Brian Federle.
>
>
> Description
> -------
>
> 1. Log in as an admin or regular user.
> 2. On the top right corner of the UI, next to the user name, click on the arrow that is pointed downwards.
> 3. Click on the "About" Button from the dropdown list.
>
> =================
> Expected Test Results:
> =================
>
> CloudPlatform name is expected in the message.BUT "cloudstack" is currently displayed.
>
> so wrote a helper function to render the text and a regular expression would parse the rendered text and replace 'cloudstack' with 'cloudPlatform' in case it is a proprietary build.
>
>
> This addresses bug CS-15425.
>
>
> Diffs
> -----
>
> ui/scripts/ui/core.js a1c58a7
>
> Diff: https://reviews.apache.org/r/5811/diff/
>
>
> Testing
> -------
>
> Verified on my local cloudstack set up.Attached the screenshot after the helpder function was added by me to get the desired output.
>
>
> Thanks,
>
> Pranav Saxena
>
>
Re: Review Request: CS-15425: Clicking on "About" button - Message refers to
CloudStack instead of CloudPlatform(p1)
Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5811/#review8924
-----------------------------------------------------------
This is not at all the desired output.
This is Apache CloudStack, and the about should reference "Apache CloudStack"
- David Nalley
On July 6, 2012, 6:33 p.m., Pranav Saxena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5811/
> -----------------------------------------------------------
>
> (Updated July 6, 2012, 6:33 p.m.)
>
>
> Review request for cloudstack and Brian Federle.
>
>
> Description
> -------
>
> 1. Log in as an admin or regular user.
> 2. On the top right corner of the UI, next to the user name, click on the arrow that is pointed downwards.
> 3. Click on the "About" Button from the dropdown list.
>
> =================
> Expected Test Results:
> =================
>
> CloudPlatform name is expected in the message.BUT "cloudstack" is currently displayed.
>
> so wrote a helper function to render the text and a regular expression would parse the rendered text and replace 'cloudstack' with 'cloudPlatform' in case it is a proprietary build.
>
>
> This addresses bug CS-15425.
>
>
> Diffs
> -----
>
> ui/scripts/ui/core.js a1c58a7
>
> Diff: https://reviews.apache.org/r/5811/diff/
>
>
> Testing
> -------
>
> Verified on my local cloudstack set up.Attached the screenshot after the helpder function was added by me to get the desired output.
>
>
> Thanks,
>
> Pranav Saxena
>
>