[GitHub] [arrow] felipecrv commented on a diff in pull request #35751: GH-35765: [C++] Split vector_selection.cc into more compilation units

["felipecrv (via GitHub)" <gi...@apache.org>]

felipecrv commented on code in PR #35751:
URL: https://github.com/apache/arrow/pull/35751#discussion_r1205579229


##########
cpp/src/arrow/compute/kernels/vector_selection.cc:
##########
@@ -58,2119 +60,22 @@ using internal::OptionalBitIndexer;
 namespace compute {
 namespace internal {
 
+using FilterState = OptionsWrapper<FilterOptions>;
+using TakeState = OptionsWrapper<TakeOptions>;
+
 int64_t GetFilterOutputSize(const ArraySpan& filter,
                             FilterOptions::NullSelectionBehavior null_selection) {

Review Comment:
   It becomes this in #35750.
   ```cpp
   int64_t GetFilterOutputSize(const ArraySpan& filter,
                               FilterOptions::NullSelectionBehavior null_selection) {
     if (filter.type->id() == Type::BOOL) {
       return GetBitmapFilterOutputSize(filter, null_selection);
     }
     return GetREEFilterOutputSize(filter, null_selection);
   ```
   
    I will move it completely to `vector_selection_filter.cc` now and remove it here, but I haven't decided yet if the REEx* filter kernels are going to be implemented in `vector_selection_filter.cc` or in a separate `.cc`, so I might undo this later. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org