[jira] [Commented] (SOLR-13897) Unsafe publication of Terms object in ZkShardTerms

["Shalin Shekhar Mangar (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985459#comment-16985459 ] 

Shalin Shekhar Mangar commented on SOLR-13897:
----------------------------------------------

The onTermUpdates might receive updates out of order (i.e. monotonic term versions are not guaranteed inside onTermUpdates) but it is not a problem in the default RecoveringCoreTermWatcher implementation because it tracks the last term that triggered recovery and returns if it is greater (or equal) to the current term. This patch adds javadocs to the CoreTermWatcher interface and calls out the behavior of these invocations.

> Unsafe publication of Terms object in ZkShardTerms
> --------------------------------------------------
>
>                 Key: SOLR-13897
>                 URL: https://issues.apache.org/jira/browse/SOLR-13897
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>    Affects Versions: 8.2, 8.3
>            Reporter: Shalin Shekhar Mangar
>            Priority: Major
>             Fix For: master (9.0), 8.4
>
>         Attachments: SOLR-13897.patch, SOLR-13897.patch
>
>
> The Terms object in ZkShardTerms is written using a write lock but reading is allowed freely. This is not safe and can cause visibility issues and associated race conditions under contention.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org