You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/12/04 20:38:22 UTC
[kudu-CR] clang tidy gerrit: disable readability-magic-numbers check
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14833
Change subject: clang_tidy_gerrit: disable readability-magic-numbers check
......................................................................
clang_tidy_gerrit: disable readability-magic-numbers check
Although useful, we lean quite heavily on magic numbers in tests, and
as there's no way to disable this check in specific files, let's disable it
across the board.
Change-Id: I26c39915f4fc96078116552286248fb3eb3704cf
---
M build-support/clang_tidy_gerrit.py
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/14833/1
--
To view, visit http://gerrit.cloudera.org:8080/14833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26c39915f4fc96078116552286248fb3eb3704cf
Gerrit-Change-Number: 14833
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
[kudu-CR] clang tidy gerrit: disable readability-magic-numbers check
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14833 )
Change subject: clang_tidy_gerrit: disable readability-magic-numbers check
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c39915f4fc96078116552286248fb3eb3704cf
Gerrit-Change-Number: 14833
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 04 Dec 2019 22:06:13 +0000
Gerrit-HasComments: No
[kudu-CR] clang tidy gerrit: disable readability-magic-numbers check
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14833 )
Change subject: clang_tidy_gerrit: disable readability-magic-numbers check
......................................................................
clang_tidy_gerrit: disable readability-magic-numbers check
Although useful, we lean quite heavily on magic numbers in tests, and
as there's no way to disable this check in specific files, let's disable it
across the board.
Change-Id: I26c39915f4fc96078116552286248fb3eb3704cf
Reviewed-on: http://gerrit.cloudera.org:8080/14833
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M build-support/clang_tidy_gerrit.py
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I26c39915f4fc96078116552286248fb3eb3704cf
Gerrit-Change-Number: 14833
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] clang tidy gerrit: disable readability-magic-numbers check
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14833 )
Change subject: clang_tidy_gerrit: disable readability-magic-numbers check
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I26c39915f4fc96078116552286248fb3eb3704cf
Gerrit-Change-Number: 14833
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] clang tidy gerrit: disable readability-magic-numbers check
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14833 )
Change subject: clang_tidy_gerrit: disable readability-magic-numbers check
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, TSAN failure is fixed in https://gerrit.cloudera.org/c/14835.
--
To view, visit http://gerrit.cloudera.org:8080/14833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c39915f4fc96078116552286248fb3eb3704cf
Gerrit-Change-Number: 14833
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 04 Dec 2019 21:26:09 +0000
Gerrit-HasComments: No