You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/02/28 11:15:31 UTC

[GitHub] [doris] morningman opened a new pull request, #17244: [fix](hdfs) fix BE crash when hdfs-site.xml not exist in be/conf

morningman opened a new pull request, #17244:
URL: https://github.com/apache/doris/pull/17244

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   We set `LIBHDFS3_CONF` env in `start_be.sh`, so libhdfs3 will try to read this `hdfs-site.xml`,
   if file does not exist, it will throw error. But Doris does not handle this error, cause BE crash.
   This CL mainly changes:
   
   1. Modify `start_be.sh` to only set `LIBHDFS3_CONF` if `hdfs-site.xml` exist.
   2. Refactor the HDFSCommonBuilder so that it can return error correctly.
   3. Add BE IP info in status, so that we can get ip from error msg like:
   
   ```
   ERROR 1105 (HY000): errCode = 2, detailMessage = [INTERNAL_ERROR]failed to init reader for file  000.snappy.orc, err: 
   [INTERNAL_ERROR][172.21.0.101]failed to init HDFSCommonBuilder, please check check be/conf/hdfs-site.xml
   ```
   
   ## Checklist(Required)
   
   * [ ] Does it affect the original behavior
   * [ ] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #17244: [fix](hdfs)(catalog) fix BE crash when hdfs-site.xml not exist in be/conf and fix compute node logic

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #17244:
URL: https://github.com/apache/doris/pull/17244#issuecomment-1450201924

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #17244: [fix](hdfs)(catalog) fix BE crash when hdfs-site.xml not exist in be/conf and fix compute node logic

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #17244:
URL: https://github.com/apache/doris/pull/17244#issuecomment-1449677241

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #17244: [fix](hdfs)(catalog) fix BE crash when hdfs-site.xml not exist in be/conf and fix compute node logic

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #17244:
URL: https://github.com/apache/doris/pull/17244#issuecomment-1448523937

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17244: [fix](hdfs)(catalog) fix BE crash when hdfs-site.xml not exist in be/conf and fix compute node logic

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17244:
URL: https://github.com/apache/doris/pull/17244#issuecomment-1448367331

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4294491292") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In bin/start_be.sh line 234:
   if [ -f "${DORIS_HOME}/conf/hdfs-site.xml" ]; then
      ^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
   
   Did you mean: 
   if [[ -f "${DORIS_HOME}/conf/hdfs-site.xml" ]]; then
   
   For more information:
     https://www.shellcheck.net/wiki/SC2292 -- Prefer [[ ]] over [ ] for tests i...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   'shfmt ' found no issues.
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17244: [fix](hdfs) fix BE crash when hdfs-site.xml not exist in be/conf

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17244:
URL: https://github.com/apache/doris/pull/17244#issuecomment-1448001209

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4292366766") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In bin/start_be.sh line 234:
   if [ -f "${DORIS_HOME}/conf/hdfs-site.xml" ]; then
      ^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
   
   Did you mean: 
   if [[ -f "${DORIS_HOME}/conf/hdfs-site.xml" ]]; then
   
   For more information:
     https://www.shellcheck.net/wiki/SC2292 -- Prefer [[ ]] over [ ] for tests i...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   'shfmt ' found no issues.
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17244: [fix](hdfs)(catalog) fix BE crash when hdfs-site.xml not exist in be/conf and fix compute node logic

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #17244:
URL: https://github.com/apache/doris/pull/17244#discussion_r1120390623


##########
be/test/common/config_test.cpp:
##########
@@ -99,37 +99,43 @@ TEST_F(ConfigTest, UpdateConfigs) {
     // not exist
     Status s = config::set_config("cfg_not_exist", "123");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_FOUND]'cfg_not_exist' is not found");
+    EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   ```cpp
       EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);
                     ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1981:** expanded from macro 'EXPECT_TRUE'
   ```cpp
   #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
                                                    ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1965:** expanded from macro 'GTEST_EXPECT_TRUE'
   ```cpp
     GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
                         ^
   ```
   **thirdparty/installed/include/gtest/internal/gtest-internal.h:1501:** expanded from macro 'GTEST_TEST_BOOLEAN_'
   ```cpp
         ::testing::AssertionResult(expression)) \
                                    ^
   ```
   



##########
be/test/common/config_test.cpp:
##########
@@ -99,37 +99,43 @@
     // not exist
     Status s = config::set_config("cfg_not_exist", "123");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_FOUND]'cfg_not_exist' is not found");
+    EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_not_exist' is not found") != std::string::npos);
 
     // immutable
     EXPECT_TRUE(cfg_bool_immutable);
     s = config::set_config("cfg_bool_immutable", "false");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(),
-              "[NOT_IMPLEMENTED_ERROR]'cfg_bool_immutable' is not support to modify");
+    EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   ```cpp
       EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);
                     ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1981:** expanded from macro 'EXPECT_TRUE'
   ```cpp
   #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
                                                    ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1965:** expanded from macro 'GTEST_EXPECT_TRUE'
   ```cpp
     GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
                         ^
   ```
   **thirdparty/installed/include/gtest/internal/gtest-internal.h:1501:** expanded from macro 'GTEST_TEST_BOOLEAN_'
   ```cpp
         ::testing::AssertionResult(expression)) \
                                    ^
   ```
   



##########
be/test/common/config_test.cpp:
##########
@@ -99,37 +99,43 @@
     // not exist
     Status s = config::set_config("cfg_not_exist", "123");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_FOUND]'cfg_not_exist' is not found");
+    EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_not_exist' is not found") != std::string::npos);
 
     // immutable
     EXPECT_TRUE(cfg_bool_immutable);
     s = config::set_config("cfg_bool_immutable", "false");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(),
-              "[NOT_IMPLEMENTED_ERROR]'cfg_bool_immutable' is not support to modify");
+    EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_bool_immutable' is not support to modify") !=
+                std::string::npos);
     EXPECT_TRUE(cfg_bool_immutable);
 
     // convert error
     s = config::set_config("cfg_bool", "falseeee");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert 'falseeee' as bool failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert 'falseeee' as bool failed") != std::string::npos);

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   ```cpp
       EXPECT_TRUE(s.to_string.find("convert 'falseeee' as bool failed") != std::string::npos);
                     ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1981:** expanded from macro 'EXPECT_TRUE'
   ```cpp
   #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
                                                    ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1965:** expanded from macro 'GTEST_EXPECT_TRUE'
   ```cpp
     GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
                         ^
   ```
   **thirdparty/installed/include/gtest/internal/gtest-internal.h:1501:** expanded from macro 'GTEST_TEST_BOOLEAN_'
   ```cpp
         ::testing::AssertionResult(expression)) \
                                    ^
   ```
   



##########
be/test/common/config_test.cpp:
##########
@@ -99,37 +99,43 @@
     // not exist
     Status s = config::set_config("cfg_not_exist", "123");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_FOUND]'cfg_not_exist' is not found");
+    EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_not_exist' is not found") != std::string::npos);
 
     // immutable
     EXPECT_TRUE(cfg_bool_immutable);
     s = config::set_config("cfg_bool_immutable", "false");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(),
-              "[NOT_IMPLEMENTED_ERROR]'cfg_bool_immutable' is not support to modify");
+    EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_bool_immutable' is not support to modify") !=
+                std::string::npos);
     EXPECT_TRUE(cfg_bool_immutable);
 
     // convert error
     s = config::set_config("cfg_bool", "falseeee");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert 'falseeee' as bool failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert 'falseeee' as bool failed") != std::string::npos);
     EXPECT_TRUE(cfg_bool);
 
     s = config::set_config("cfg_double", "");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert '' as double failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   ```cpp
       EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
                     ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1981:** expanded from macro 'EXPECT_TRUE'
   ```cpp
   #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
                                                    ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1965:** expanded from macro 'GTEST_EXPECT_TRUE'
   ```cpp
     GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
                         ^
   ```
   **thirdparty/installed/include/gtest/internal/gtest-internal.h:1501:** expanded from macro 'GTEST_TEST_BOOLEAN_'
   ```cpp
         ::testing::AssertionResult(expression)) \
                                    ^
   ```
   



##########
be/test/common/config_test.cpp:
##########
@@ -99,37 +99,43 @@
     // not exist
     Status s = config::set_config("cfg_not_exist", "123");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_FOUND]'cfg_not_exist' is not found");
+    EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_not_exist' is not found") != std::string::npos);
 
     // immutable
     EXPECT_TRUE(cfg_bool_immutable);
     s = config::set_config("cfg_bool_immutable", "false");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(),
-              "[NOT_IMPLEMENTED_ERROR]'cfg_bool_immutable' is not support to modify");
+    EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_bool_immutable' is not support to modify") !=

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   ```cpp
       EXPECT_TRUE(s.to_string.find("'cfg_bool_immutable' is not support to modify") !=
                     ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1981:** expanded from macro 'EXPECT_TRUE'
   ```cpp
   #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
                                                    ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1965:** expanded from macro 'GTEST_EXPECT_TRUE'
   ```cpp
     GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
                         ^
   ```
   **thirdparty/installed/include/gtest/internal/gtest-internal.h:1501:** expanded from macro 'GTEST_TEST_BOOLEAN_'
   ```cpp
         ::testing::AssertionResult(expression)) \
                                    ^
   ```
   



##########
be/test/common/config_test.cpp:
##########
@@ -99,37 +99,43 @@
     // not exist
     Status s = config::set_config("cfg_not_exist", "123");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_FOUND]'cfg_not_exist' is not found");
+    EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_not_exist' is not found") != std::string::npos);

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   ```cpp
       EXPECT_TRUE(s.to_string.find("'cfg_not_exist' is not found") != std::string::npos);
                     ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1981:** expanded from macro 'EXPECT_TRUE'
   ```cpp
   #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
                                                    ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1965:** expanded from macro 'GTEST_EXPECT_TRUE'
   ```cpp
     GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
                         ^
   ```
   **thirdparty/installed/include/gtest/internal/gtest-internal.h:1501:** expanded from macro 'GTEST_TEST_BOOLEAN_'
   ```cpp
         ::testing::AssertionResult(expression)) \
                                    ^
   ```
   



##########
be/test/common/config_test.cpp:
##########
@@ -99,37 +99,43 @@
     // not exist
     Status s = config::set_config("cfg_not_exist", "123");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_FOUND]'cfg_not_exist' is not found");
+    EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_not_exist' is not found") != std::string::npos);
 
     // immutable
     EXPECT_TRUE(cfg_bool_immutable);
     s = config::set_config("cfg_bool_immutable", "false");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(),
-              "[NOT_IMPLEMENTED_ERROR]'cfg_bool_immutable' is not support to modify");
+    EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_bool_immutable' is not support to modify") !=
+                std::string::npos);
     EXPECT_TRUE(cfg_bool_immutable);
 
     // convert error
     s = config::set_config("cfg_bool", "falseeee");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert 'falseeee' as bool failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   ```cpp
       EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
                     ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1981:** expanded from macro 'EXPECT_TRUE'
   ```cpp
   #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
                                                    ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1965:** expanded from macro 'GTEST_EXPECT_TRUE'
   ```cpp
     GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
                         ^
   ```
   **thirdparty/installed/include/gtest/internal/gtest-internal.h:1501:** expanded from macro 'GTEST_TEST_BOOLEAN_'
   ```cpp
         ::testing::AssertionResult(expression)) \
                                    ^
   ```
   



##########
be/test/common/config_test.cpp:
##########
@@ -99,37 +99,43 @@
     // not exist
     Status s = config::set_config("cfg_not_exist", "123");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_FOUND]'cfg_not_exist' is not found");
+    EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_not_exist' is not found") != std::string::npos);
 
     // immutable
     EXPECT_TRUE(cfg_bool_immutable);
     s = config::set_config("cfg_bool_immutable", "false");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(),
-              "[NOT_IMPLEMENTED_ERROR]'cfg_bool_immutable' is not support to modify");
+    EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_bool_immutable' is not support to modify") !=
+                std::string::npos);
     EXPECT_TRUE(cfg_bool_immutable);
 
     // convert error
     s = config::set_config("cfg_bool", "falseeee");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert 'falseeee' as bool failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert 'falseeee' as bool failed") != std::string::npos);
     EXPECT_TRUE(cfg_bool);
 
     s = config::set_config("cfg_double", "");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert '' as double failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert '' as double failed") != std::string::npos);

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   ```cpp
       EXPECT_TRUE(s.to_string.find("convert '' as double failed") != std::string::npos);
                     ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1981:** expanded from macro 'EXPECT_TRUE'
   ```cpp
   #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
                                                    ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1965:** expanded from macro 'GTEST_EXPECT_TRUE'
   ```cpp
     GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
                         ^
   ```
   **thirdparty/installed/include/gtest/internal/gtest-internal.h:1501:** expanded from macro 'GTEST_TEST_BOOLEAN_'
   ```cpp
         ::testing::AssertionResult(expression)) \
                                    ^
   ```
   



##########
be/test/common/config_test.cpp:
##########
@@ -99,37 +99,43 @@
     // not exist
     Status s = config::set_config("cfg_not_exist", "123");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_FOUND]'cfg_not_exist' is not found");
+    EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_not_exist' is not found") != std::string::npos);
 
     // immutable
     EXPECT_TRUE(cfg_bool_immutable);
     s = config::set_config("cfg_bool_immutable", "false");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(),
-              "[NOT_IMPLEMENTED_ERROR]'cfg_bool_immutable' is not support to modify");
+    EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_bool_immutable' is not support to modify") !=
+                std::string::npos);
     EXPECT_TRUE(cfg_bool_immutable);
 
     // convert error
     s = config::set_config("cfg_bool", "falseeee");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert 'falseeee' as bool failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert 'falseeee' as bool failed") != std::string::npos);
     EXPECT_TRUE(cfg_bool);
 
     s = config::set_config("cfg_double", "");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert '' as double failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert '' as double failed") != std::string::npos);
     EXPECT_EQ(cfg_double, 654.321);
 
     // convert error
     s = config::set_config("cfg_int32_t", "4294967296124");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert '4294967296124' as int32_t failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   ```cpp
       EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
                     ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1981:** expanded from macro 'EXPECT_TRUE'
   ```cpp
   #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
                                                    ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1965:** expanded from macro 'GTEST_EXPECT_TRUE'
   ```cpp
     GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
                         ^
   ```
   **thirdparty/installed/include/gtest/internal/gtest-internal.h:1501:** expanded from macro 'GTEST_TEST_BOOLEAN_'
   ```cpp
         ::testing::AssertionResult(expression)) \
                                    ^
   ```
   



##########
be/test/common/config_test.cpp:
##########
@@ -99,37 +99,43 @@
     // not exist
     Status s = config::set_config("cfg_not_exist", "123");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_FOUND]'cfg_not_exist' is not found");
+    EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_not_exist' is not found") != std::string::npos);
 
     // immutable
     EXPECT_TRUE(cfg_bool_immutable);
     s = config::set_config("cfg_bool_immutable", "false");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(),
-              "[NOT_IMPLEMENTED_ERROR]'cfg_bool_immutable' is not support to modify");
+    EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_bool_immutable' is not support to modify") !=
+                std::string::npos);
     EXPECT_TRUE(cfg_bool_immutable);
 
     // convert error
     s = config::set_config("cfg_bool", "falseeee");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert 'falseeee' as bool failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert 'falseeee' as bool failed") != std::string::npos);
     EXPECT_TRUE(cfg_bool);
 
     s = config::set_config("cfg_double", "");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert '' as double failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert '' as double failed") != std::string::npos);
     EXPECT_EQ(cfg_double, 654.321);
 
     // convert error
     s = config::set_config("cfg_int32_t", "4294967296124");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert '4294967296124' as int32_t failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert '4294967296124' as int32_t failed") != std::string::npos);
     EXPECT_EQ(cfg_int32_t, 65536124);
 
     // not support
     s = config::set_config("cfg_std_string", "test");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_IMPLEMENTED_ERROR]'cfg_std_string' is not support to modify");
+    EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   ```cpp
       EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);
                     ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1981:** expanded from macro 'EXPECT_TRUE'
   ```cpp
   #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
                                                    ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1965:** expanded from macro 'GTEST_EXPECT_TRUE'
   ```cpp
     GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
                         ^
   ```
   **thirdparty/installed/include/gtest/internal/gtest-internal.h:1501:** expanded from macro 'GTEST_TEST_BOOLEAN_'
   ```cpp
         ::testing::AssertionResult(expression)) \
                                    ^
   ```
   



##########
be/test/common/config_test.cpp:
##########
@@ -99,37 +99,43 @@
     // not exist
     Status s = config::set_config("cfg_not_exist", "123");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_FOUND]'cfg_not_exist' is not found");
+    EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_not_exist' is not found") != std::string::npos);
 
     // immutable
     EXPECT_TRUE(cfg_bool_immutable);
     s = config::set_config("cfg_bool_immutable", "false");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(),
-              "[NOT_IMPLEMENTED_ERROR]'cfg_bool_immutable' is not support to modify");
+    EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_bool_immutable' is not support to modify") !=
+                std::string::npos);
     EXPECT_TRUE(cfg_bool_immutable);
 
     // convert error
     s = config::set_config("cfg_bool", "falseeee");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert 'falseeee' as bool failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert 'falseeee' as bool failed") != std::string::npos);
     EXPECT_TRUE(cfg_bool);
 
     s = config::set_config("cfg_double", "");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert '' as double failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert '' as double failed") != std::string::npos);
     EXPECT_EQ(cfg_double, 654.321);
 
     // convert error
     s = config::set_config("cfg_int32_t", "4294967296124");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert '4294967296124' as int32_t failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert '4294967296124' as int32_t failed") != std::string::npos);

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   ```cpp
       EXPECT_TRUE(s.to_string.find("convert '4294967296124' as int32_t failed") != std::string::npos);
                     ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1981:** expanded from macro 'EXPECT_TRUE'
   ```cpp
   #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
                                                    ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1965:** expanded from macro 'GTEST_EXPECT_TRUE'
   ```cpp
     GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
                         ^
   ```
   **thirdparty/installed/include/gtest/internal/gtest-internal.h:1501:** expanded from macro 'GTEST_TEST_BOOLEAN_'
   ```cpp
         ::testing::AssertionResult(expression)) \
                                    ^
   ```
   



##########
be/test/common/config_test.cpp:
##########
@@ -99,37 +99,43 @@
     // not exist
     Status s = config::set_config("cfg_not_exist", "123");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_FOUND]'cfg_not_exist' is not found");
+    EXPECT_TRUE(s.to_string.find("[NOT_FOUND]") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_not_exist' is not found") != std::string::npos);
 
     // immutable
     EXPECT_TRUE(cfg_bool_immutable);
     s = config::set_config("cfg_bool_immutable", "false");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(),
-              "[NOT_IMPLEMENTED_ERROR]'cfg_bool_immutable' is not support to modify");
+    EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_bool_immutable' is not support to modify") !=
+                std::string::npos);
     EXPECT_TRUE(cfg_bool_immutable);
 
     // convert error
     s = config::set_config("cfg_bool", "falseeee");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert 'falseeee' as bool failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert 'falseeee' as bool failed") != std::string::npos);
     EXPECT_TRUE(cfg_bool);
 
     s = config::set_config("cfg_double", "");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert '' as double failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert '' as double failed") != std::string::npos);
     EXPECT_EQ(cfg_double, 654.321);
 
     // convert error
     s = config::set_config("cfg_int32_t", "4294967296124");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[INVALID_ARGUMENT]convert '4294967296124' as int32_t failed");
+    EXPECT_TRUE(s.to_string.find("INVALID_ARGUMENT") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("convert '4294967296124' as int32_t failed") != std::string::npos);
     EXPECT_EQ(cfg_int32_t, 65536124);
 
     // not support
     s = config::set_config("cfg_std_string", "test");
     EXPECT_FALSE(s.ok());
-    EXPECT_EQ(s.to_string(), "[NOT_IMPLEMENTED_ERROR]'cfg_std_string' is not support to modify");
+    EXPECT_TRUE(s.to_string.find("NOT_IMPLEMENTED_ERROR") != std::string::npos);
+    EXPECT_TRUE(s.to_string.find("'cfg_std_string' is not support to modify") != std::string::npos);

Review Comment:
   warning: reference to non-static member function must be called; did you mean to call it with no arguments? [clang-diagnostic-error]
   ```cpp
       EXPECT_TRUE(s.to_string.find("'cfg_std_string' is not support to modify") != std::string::npos);
                     ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1981:** expanded from macro 'EXPECT_TRUE'
   ```cpp
   #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
                                                    ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:1965:** expanded from macro 'GTEST_EXPECT_TRUE'
   ```cpp
     GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
                         ^
   ```
   **thirdparty/installed/include/gtest/internal/gtest-internal.h:1501:** expanded from macro 'GTEST_TEST_BOOLEAN_'
   ```cpp
         ::testing::AssertionResult(expression)) \
                                    ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #17244: [fix](hdfs)(catalog) fix BE crash when hdfs-site.xml not exist in be/conf and fix compute node logic

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #17244:
URL: https://github.com/apache/doris/pull/17244#issuecomment-1448398705

   run buidall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] SaintBacchus commented on a diff in pull request #17244: [fix](hdfs)(catalog) fix BE crash when hdfs-site.xml not exist in be/conf and fix compute node logic

Posted by "SaintBacchus (via GitHub)" <gi...@apache.org>.
SaintBacchus commented on code in PR #17244:
URL: https://github.com/apache/doris/pull/17244#discussion_r1121208642


##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1828,12 +1828,20 @@ public class Config extends ConfigBase {
     public static boolean keep_scheduler_mtmv_task_when_job_deleted = false;
 
     /**
-     * The candidate of the backend node for federation query such as hive table and es table query.
-     * If the backend of computation role is less than this value, it will acquire some mix backend.
-     * If the computation backend is enough, federation query will only assign to computation backend.
+     * If set to true, query on external table will prefer to assign to compute node.
+     * And the max number of compute node is controlled by min_backend_num_for_external_table.
+     * If set to false, query on external table will assign to any node.
      */
     @ConfField(mutable = true, masterOnly = false)
-    public static int backend_num_for_federation = 3;
+    public static boolean prefer_compute_node_for_external_table = false;

Review Comment:
   It's better than before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #17244: [fix](hdfs)(catalog) fix BE crash when hdfs-site.xml not exist in be/conf and fix compute node logic

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #17244:
URL: https://github.com/apache/doris/pull/17244#issuecomment-1448498279

   run buidall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17244: [fix](hdfs) fix BE crash when hdfs-site.xml not exist in be/conf

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17244:
URL: https://github.com/apache/doris/pull/17244#issuecomment-1448189779

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4293520191") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In bin/start_be.sh line 234:
   if [ -f "${DORIS_HOME}/conf/hdfs-site.xml" ]; then
      ^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
   
   Did you mean: 
   if [[ -f "${DORIS_HOME}/conf/hdfs-site.xml" ]]; then
   
   For more information:
     https://www.shellcheck.net/wiki/SC2292 -- Prefer [[ ]] over [ ] for tests i...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   'shfmt ' found no issues.
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei merged pull request #17244: [fix](hdfs)(catalog) fix BE crash when hdfs-site.xml not exist in be/conf and fix compute node logic

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #17244:
URL: https://github.com/apache/doris/pull/17244


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17244: [fix](hdfs) fix BE crash when hdfs-site.xml not exist in be/conf

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #17244:
URL: https://github.com/apache/doris/pull/17244#discussion_r1119915658


##########
be/src/io/hdfs_builder.h:
##########
@@ -31,13 +31,20 @@ const std::string KERBEROS_KEYTAB = "hadoop.kerberos.keytab";
 const std::string TICKET_CACHE_PATH = "/tmp/krb5cc_doris_";
 
 class HDFSCommonBuilder {
-    friend HDFSCommonBuilder createHDFSBuilder(const THdfsParams& hdfsParams);
-    friend HDFSCommonBuilder createHDFSBuilder(
-            const std::map<std::string, std::string>& properties);
+    friend Status createHDFSBuilder(const THdfsParams& hdfsParams, HDFSCommonBuilder* builder);
+    friend Status createHDFSBuilder(const std::map<std::string, std::string>& properties,
+                                    HDFSCommonBuilder* builder);
 
 public:
-    HDFSCommonBuilder() : hdfs_builder(hdfsNewBuilder()) {}
-    ~HDFSCommonBuilder() { hdfsFreeBuilder(hdfs_builder); }
+    HDFSCommonBuilder() {}

Review Comment:
   warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
   
   ```suggestion
       HDFSCommonBuilder() = default;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org