You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philip M. Gollucci" <pg...@p6m7g8.com> on 2005/07/17 03:23:46 UTC
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Philip M. Gollucci wrote:
>> URL: http://svn.apache.org/viewcvs?rev=202272&view=rev
>> Log:
>> skip on 2.1 until I have the time to figure out what changed
This patch fixes the content_length_header tests so we don't have to
skip them. (attached)
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Philip M. Gollucci wrote:
> Geoffrey Young wrote:
>
>>>
>>>
>>>>> + my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>>>> + my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>>>>>
>>>>> + my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>>>> + my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>>>>>
>
> Ahh you just meant the ? returning the same thing in both cases.
> Should I commit after fixing that to be simpler ?
sure :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Geoffrey Young wrote:
>>
>>
>>>>+ my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>>>+ my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>>>>
>>>>
>>>>+ my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>>>+ my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>>>>
>>>>
Ahh you just meant the ? returning the same thing in both cases.
Should I commit after fixing that to be simpler ?
--
END
---------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Philip M. Gollucci wrote:
> Geoffrey Young wrote:
>
>>> + my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>> + my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>>
>>
>>
>>> + my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>> + my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>>
>>
>>
>> that looks awfully odd :)
>>
>> --Geoff
>
> I'll do some more digging during the week. :)
I hope you know it was just the syntax I was winking at :)
from your patch it looks like 2.1 behavior was "fixed" to match 2.0, which
is great. and if that's true we only need one definition I'd think, not ? :
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Geoffrey Young wrote:
>>+ my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>+ my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>
>
>>+ my $cl = have_min_apache_version(2.1) ? 0 : 0;
>>+ my $head_cl = have_min_apache_version(2.1) ? undef : undef;
>
>
> that looks awfully odd :)
>
> --Geoff
I'll do some more digging during the week. :)
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r202272 - /perl/modperl/trunk/t/apache/content_length_header.t
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> + my $cl = have_min_apache_version(2.1) ? 0 : 0;
> + my $head_cl = have_min_apache_version(2.1) ? undef : undef;
> + my $cl = have_min_apache_version(2.1) ? 0 : 0;
> + my $head_cl = have_min_apache_version(2.1) ? undef : undef;
that looks awfully odd :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org