[jira] [Comment Edited] (ROCKETMQ-204) all brokers were down but client still report heartbeat

["Jaskey Lam (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040106#comment-16040106 ] 

Jaskey Lam edited comment on ROCKETMQ-204 at 6/7/17 3:38 AM:
-------------------------------------------------------------

The problem is because when update topic route info from nameserver, the local topicRouteInfo table is only updated when the result from nameserver is not null.

{code}

                    if (topicRouteData != null) {
                         //update info table here
                    } else {
                        //do nothing but log
                        log.warn("updateTopicRouteInfoFromNameServer, getTopicRouteInfoFromNameServer return null. Topic: {}", topic);
                    }

{code}

This results client will not consider the broker is offline already , so heartbeat will be continue to send but the attempts will actually fail always.


was (Author: jaskey):
The problem is because when update topic route info from nameserver, the local topicRouteInfo table is only updated when the result from nameserver is not null.

{code}

                    if (topicRouteData != null) {
                         //update info table here
                    } else {
                        //do nothing but log
                        log.warn("updateTopicRouteInfoFromNameServer, getTopicRouteInfoFromNameServer return null. Topic: {}", topic);
                    }

{code}

> all brokers were down but client still report heartbeat
> -------------------------------------------------------
>
>                 Key: ROCKETMQ-204
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-204
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-broker, rocketmq-client
>            Reporter: Eason Chen
>            Assignee: yukon
>
> all brokers were down but client still hold at least one broker adresss and report heartbeat to it. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)