DO NOT REPLY [Bug 21127] New: - Using class members instead of getters and setters in BaseHandlerTag class

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21127>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21127

Using class members instead of getters and setters in BaseHandlerTag class

           Summary: Using class members instead of getters and setters in
                    BaseHandlerTag class
           Product: Struts
           Version: 1.1RC2
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Custom Tags
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: mstolpner@canada.com


The following code from BaseHandlerTag class looks as a bug to me. It's mixing 
direct access to member and getXXX method usage. If you try to overload 
getOnclick that will cause a problem.

if (onclick != null) {
 handlers.append(" onclick=\"");
 handlers.append(getOnclick());
 handlers.append("\"");
}

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org