You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/01/11 11:17:40 UTC
Re: Review Request 55417: Log Search: default search ranges don't
look right
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55417/
-----------------------------------------------------------
(Updated Jan. 11, 2017, 11:17 a.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
fixed summary
Summary (updated)
-----------------
Log Search: default search ranges don't look right
Bugs: AMBARI-19461
https://issues.apache.org/jira/browse/AMBARI-19461
Repository: ambari
Description
-------
The start time for the default search ranges (except for last 1 hour) start at 00:00:01,000 and the end time is 23:59:59,999.
The start time should be 00:00:00,000 instead.
For last 1 hour, it looks like the range has the opposite problem of the window being a little too bug. For example: 12/12/2016 15:35:11,062 - 12/12/2016 16:36:12,063
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Utils.js 94a8a5b
Diff: https://reviews.apache.org/r/55417/diff/
Testing
-------
Tested on local cluster, ranges were fine
Thanks,
Miklos Gergely
Re: Review Request 55417: Log Search: default search ranges don't
look right
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55417/#review161379
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Jan. 11, 2017, 11:17 a.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55417/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 11:17 a.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-19461
> https://issues.apache.org/jira/browse/AMBARI-19461
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The start time for the default search ranges (except for last 1 hour) start at 00:00:01,000 and the end time is 23:59:59,999.
> The start time should be 00:00:00,000 instead.
> For last 1 hour, it looks like the range has the opposite problem of the window being a little too bug. For example: 12/12/2016 15:35:11,062 - 12/12/2016 16:36:12,063
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Utils.js 94a8a5b
>
> Diff: https://reviews.apache.org/r/55417/diff/
>
>
> Testing
> -------
>
> Tested on local cluster, ranges were fine
>
>
> Thanks,
>
> Miklos Gergely
>
>