You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/22 13:50:20 UTC
[GitHub] [arrow] kszucs commented on a change in pull request #10571: ARROW-8459: [Dev][Archery] Use a more recent cmake-format
kszucs commented on a change in pull request #10571:
URL: https://github.com/apache/arrow/pull/10571#discussion_r656241594
##########
File path: cpp/cmake_modules/DefineOptions.cmake
##########
@@ -104,33 +112,36 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
define_option(ARROW_USE_PRECOMPILED_HEADERS "Use precompiled headers when compiling"
OFF)
- define_option_string(ARROW_SIMD_LEVEL
- "Compile-time SIMD optimization level"
- "SSE4_2" # default to SSE4.2
- "NONE"
- "SSE4_2"
- "AVX2"
- "AVX512")
-
- define_option_string(ARROW_RUNTIME_SIMD_LEVEL
- "Max runtime SIMD optimization level"
- "MAX" # default to max supported by compiler
- "NONE"
- "SSE4_2"
- "AVX2"
- "AVX512"
- "MAX")
+ define_option_string(
Review comment:
I think we can alter this tabulation behavior using https://cmake-format.readthedocs.io/en/latest/configopts.html#min-prefix-chars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org