You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/08 00:46:01 UTC
[GitHub] [cordova-plugin-splashscreen] terreng commented on a change in pull request #286: (docs): Add Information about how to use Dark Mode SplashScreens
terreng commented on a change in pull request #286:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/286#discussion_r467337709
##########
File path: README.md
##########
@@ -177,6 +179,13 @@ If not all DPI images are considered, some devices might not show a SplashScreen
| xxhdpi | 960x1600 | 1600x960 |
| xxxhdpi | 1280x1920 | 1920x1280 |
+#### Dark Mode (API 28+)
+
+You can easily provide an extra SplashScreen image for NightMode/DarkMode enabled devices.
+To do this, add the keyword `-night` in between the image's **layout** and **size** keywords of the `density` attribute value. E.g.: `land-night-hdpi`
Review comment:
```suggestion
To do this, add the `-night` keyword in between the **layout** and **size** keywords of the image's `density` attribute value. E.g.: `land-night-hdpi`
```
##########
File path: README.md
##########
@@ -177,6 +179,13 @@ If not all DPI images are considered, some devices might not show a SplashScreen
| xxhdpi | 960x1600 | 1600x960 |
| xxxhdpi | 1280x1920 | 1920x1280 |
+#### Dark Mode (API 28+)
+
+You can easily provide an extra SplashScreen image for NightMode/DarkMode enabled devices.
Review comment:
```suggestion
You can optionally provide an extra SplashScreen image to be used in dark/night mode when enabled on supported devices.
```
##########
File path: README.md
##########
@@ -343,6 +367,23 @@ The above looks like the following in `config.xml`:
<splash src="res/screen/ios/Default@2x~ipad~comany.png" />
```
+##### Dark Mode
+
+Since [Cordova-ios@6.1.0](https://github.com/apache/cordova-ios) it is now possible to use optionally different splashscreen images when your app is running in dark mode. You can configure these images in config.xml with the ~dark suffix (and ~light is also supported).
+
+```xml
+<!-- Default image to be used for all modes -->
+<splash src="res/screen/ios/Default@2x~universal~anyany.png" />
+
+<!-- Image to use specifically for dark mode devices -->
+<splash src="res/screen/ios/Default@2x~universal~anyany~dark.png" />
+
+<!-- Image to use specifically for light mode devices -->
+<splash src="res/screen/ios/Default@2x~universal~anyany~light.png" />
+```
+
+**Note:** This works since iOS13+. Version below will use the default SplashScreen without a luminosity suffix specified.
Review comment:
```suggestion
**Note:** This works since iOS 13. iOS 12 and below will use the default SplashScreen without a luminosity suffix specified.
```
##########
File path: README.md
##########
@@ -343,6 +367,23 @@ The above looks like the following in `config.xml`:
<splash src="res/screen/ios/Default@2x~ipad~comany.png" />
```
+##### Dark Mode
+
+Since [Cordova-ios@6.1.0](https://github.com/apache/cordova-ios) it is now possible to use optionally different splashscreen images when your app is running in dark mode. You can configure these images in config.xml with the ~dark suffix (and ~light is also supported).
Review comment:
```suggestion
Since [Cordova-ios@6.1.0](https://github.com/apache/cordova-ios) it is now possible to optionally specify different SplashScreen images to be used when your app is running in dark mode. You can specify the luminosity of SplashScreen images in config.xml using the ~dark and ~light suffixes.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org