You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2015/03/22 13:27:45 UTC
[GitHub] tajo pull request: TAJO-1437: Resolve findbug warnings on Tajo JDB...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/tajo/pull/447
TAJO-1437: Resolve findbug warnings on Tajo JDBC Module
- Performance: Replace 'new String("UDF")' into 'private static final String'.
- Bugfix: execute() saves the result set, now.
- Unused variable: warningChain is defined but always set to null.
- Standard compliance: raise SQLException on operation with a closed connection
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/tajo TAJO-1437
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/447.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #447
----
commit 779591fd9d8ccc248429df293b9d2d9c2d545c82
Author: Dongjoon Hyun <do...@apache.org>
Date: 2015-03-22T12:22:30Z
TAJO-1437: Resolve findbug warnings on Tajo JDBC Module
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1437: Resolve findbug warnings on Tajo JDB...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/447#issuecomment-87404772
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1437: Resolve findbug warnings on Tajo JDB...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/tajo/pull/447#issuecomment-85829082
Rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1437: Resolve findbug warnings on Tajo JDB...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/tajo/pull/447#issuecomment-84598836
It passed the following command.
```
mvn clean install -Pparallel-test,hcatalog-0.12.0 -DLOG_LEVEL=INFO -Dmaven.fork.count=2 > TAJO-1437.travis.log.INFO.txt
```
Result is here. https://app.box.com/s/07oenp32etnrhgwygoq6yz213lnubzpc (72MB)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1437: Resolve findbug warnings on Tajo JDB...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/447
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---