You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "bobbai00 (via GitHub)" <gi...@apache.org> on 2026/05/03 01:07:52 UTC
[PR] ci: nightly strict license-binary check that files a tracking issue on drift [texera]
bobbai00 opened a new pull request, #4734:
URL: https://github.com/apache/texera/pull/4734
### What changes were proposed in this PR?
New workflow `.github/workflows/license-binary-nightly.yml` — the second sub-task of the license-binary relaxation effort (#4691 was the first; this is #4692).
PR builds run `check_binary_deps.py` with `--ignore-transitive-version` so benign upstream version bumps on transitive deps don't block unrelated PRs. With that relaxation in place, transitive version drift would otherwise become invisible. This nightly job runs the same four checks **without** that flag — strict exact-match — and surfaces drift through a single GitHub issue:
- **Trigger:** `schedule` at 07:00 UTC daily, plus `workflow_dispatch` for manual runs.
- **Per-ecosystem jobs** (`frontend-npm`, `agent-npm`, `python`, `jar`) each rebuild the dist the same way `build.yml` does and invoke the strict check. `continue-on-error: true` on the check step ensures one ecosystem failing doesn't skip the others; per-job results are uploaded as artifacts.
- **`jar` job** runs a unified check across every dist's `lib/` directory rather than a per-service matrix. Per-service placement errors are already caught by `build.yml` on every PR; the nightly's job is exact-version drift, which the unified check surfaces just as well at a fraction of the matrix cost.
- **`report` job** (`needs: [...]`, `if: always()`) downloads the per-ecosystem artifacts and runs an `actions/github-script` step that:
- finds the open issue tagged with the stable label `license-binary-drift`,
- **on drift** — updates that issue's body with the per-ecosystem diff (or creates one if none exists, labeling it `license-binary-drift` + `ci`),
- **on clean run** — closes the open tracking issue (with an explanatory comment) so the steady state is empty,
- **off the default branch** — skips issue management entirely so `workflow_dispatch` on feature branches still runs the checks but does not surface issues.
- **Required-checks gate:** unaffected — this workflow runs on its own schedule and is not referenced from `required-checks.yml`.
### Any related issues, documentation, discussions?
Resolves #4692. Sibling: #4691 / #4693 (PR-time relaxation that this nightly counterbalances). Parent: #4688.
### How was this PR tested?
YAML structure validated with PyYAML; the embedded `actions/github-script` body run end-to-end under Node with stubbed `github` / `context` / `core` against three scenarios:
| Scenario | Behavior |
| --- | --- |
| Drift on `main`, existing tracking issue | Update issue title + body, log "Updated tracking issue #N" |
| Drift on `main`, no existing issue | Create issue with stable label `license-binary-drift` + `ci` |
| Drift but ref is `refs/heads/feature-branch` (workflow_dispatch) | Log "Not on default branch; skipping" — no issue surfaced |
| Clean run, existing tracking issue | Close issue with explanatory comment |
| Clean run, no existing issue | No-op |
Cron-vs-manual semantics tested by toggling `eventName` between `schedule` and `workflow_dispatch` in the stub `context`. The first real nightly run after merge will exercise the workflow against the live combined LICENSE-binary on `main`.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: nightly strict license-binary check that files a tracking issue on drift [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #4734:
URL: https://github.com/apache/texera/pull/4734#discussion_r3177759413
##########
.github/workflows/build.yml:
##########
@@ -56,6 +56,15 @@ on:
required: false
type: boolean
default: true
+ ignore_transitive_version:
Review Comment:
can we name it to ` --mode PR, nightly, release`? so that caller don't need to worry about those low level arguments. we may need to have other arguments in different modes later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: nightly strict license-binary check that files a tracking issue on drift [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4734:
URL: https://github.com/apache/texera/pull/4734#issuecomment-4365095767
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/4734?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 42.13%. Comparing base ([`a5b8957`](https://app.codecov.io/gh/apache/texera/commit/a5b895715e589f7f74c1459cd314861288126532?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`97fa524`](https://app.codecov.io/gh/apache/texera/commit/97fa5240abe8601724873ac55f1316ba13550cad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #4734 +/- ##
=========================================
Coverage 42.13% 42.13%
Complexity 2001 2001
=========================================
Files 957 957
Lines 34094 34094
Branches 3753 3753
=========================================
Hits 14364 14364
Misses 18952 18952
Partials 778 778
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/4734/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/4734/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `28.73% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/4734?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: nightly strict license-binary check that files a tracking issue on drift [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on code in PR #4734:
URL: https://github.com/apache/texera/pull/4734#discussion_r3177818715
##########
.github/workflows/license-binary-nightly.yml:
##########
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: License-binary nightly
+
+# PR builds run check_binary_deps.py with --ignore-transitive-version
+# (#4691, #4693) so a benign upstream version bump on a transitive dep
+# does not block merges. This workflow runs the same build.yml every
+# night on `main` with `ignore_transitive_version: false`, exercising
+# the strict exact-match check on every ecosystem. On drift, it files
+# (or updates / closes) a single tracking issue identified by the
+# stable label `license-binary-drift`. Sub-task of #4688.
+#
+# Reusing build.yml (rather than duplicating its dist-producing steps)
+# guarantees PR and nightly runs go through identical code paths — the
+# only difference between them is the value of one input.
+on:
+ schedule:
+ # 07:00 UTC daily — late evening US-Pacific, early morning Europe.
+ - cron: "0 7 * * *"
Review Comment:
changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: nightly strict license-binary check that files a tracking issue on drift [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #4734:
URL: https://github.com/apache/texera/pull/4734#discussion_r3177761069
##########
.github/workflows/license-binary-nightly.yml:
##########
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: License-binary nightly
+
+# PR builds run check_binary_deps.py with --ignore-transitive-version
+# (#4691, #4693) so a benign upstream version bump on a transitive dep
+# does not block merges. This workflow runs the same build.yml every
+# night on `main` with `ignore_transitive_version: false`, exercising
+# the strict exact-match check on every ecosystem. On drift, it files
+# (or updates / closes) a single tracking issue identified by the
+# stable label `license-binary-drift`. Sub-task of #4688.
+#
+# Reusing build.yml (rather than duplicating its dist-producing steps)
+# guarantees PR and nightly runs go through identical code paths — the
+# only difference between them is the value of one input.
+on:
+ schedule:
+ # 07:00 UTC daily — late evening US-Pacific, early morning Europe.
+ - cron: "0 7 * * *"
Review Comment:
we could do it daily first. if too frequent we can do it every 48 or 72 hours.
7:00 UTC is 12am PDT right? I think there are a lot of ppl working at this time. can we set it up to 4 or 5 am PDT instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: nightly strict license-binary check that files a tracking issue on drift [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on code in PR #4734:
URL: https://github.com/apache/texera/pull/4734#discussion_r3177761895
##########
.github/workflows/build.yml:
##########
@@ -56,6 +56,15 @@ on:
required: false
type: boolean
default: true
+ ignore_transitive_version:
Review Comment:
I think nightly and release are the same, both are exact match. PR is skipping the transitive version. Can we set the option to be "PR" and "release" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add a strict license-binary checker that files a tracking issue on license drift [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4734:
URL: https://github.com/apache/texera/pull/4734#issuecomment-4365839162
Backport to [`release/v1.1.0-incubating`](https://github.com/apache/texera/tree/release/v1.1.0-incubating) succeeded as [`f3c5352`](https://github.com/apache/texera/commit/f3c535280dd8b662d241f6b2000200e74ddba563). [Run](https://github.com/apache/texera/actions/runs/25275283468)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: add a strict license-binary checker that files a tracking issue on license drift [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 merged PR #4734:
URL: https://github.com/apache/texera/pull/4734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org