[GitHub] rob05c commented on issue #1844: DeepCachingType -- "NEVER" is now default

[GitBox <gi...@apache.org>]

rob05c commented on issue #1844: DeepCachingType -- "NEVER" is now default
URL: https://github.com/apache/incubator-trafficcontrol/pull/1844#issuecomment-362491744
 
 
   Is this ever serialised to JSON, e.g. for the Client/Server? Might need
   func (t *DeepCachingType) MarshalJSON() ([]byte, error) { return []byte(t.String()), nil } and to change func (t DeepCachingType) String() to case DeepCachingTypeNever: return "NEVER", too.
   
   That will make everything but string(t) work (which should never be done). There's no perfect solution, but this is probably the safest, and is the only way to make DeliveryService{} default to Never.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services