[GitHub] [spark] MaxGekk commented on a change in pull request #32262: [SPARK-35153][SQL] Make textual representation of ANSI interval operators more readable

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #32262:
URL: https://github.com/apache/spark/pull/32262#discussion_r616898122



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -2556,6 +2556,9 @@ case class SubtractTimestamps(
         s"new org.apache.spark.unsafe.types.CalendarInterval(0, 0, $end - $start)")
   }
 
+  override def toString: String = s"($left - $right)"
+  override def sql: String = s"(${left.sql} - ${right.sql})"

Review comment:
       I don't have good answer to your question. Probably, we could refactor SubtractDates and SubtractTimestamps.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org