You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/07 21:11:46 UTC

[GitHub] [flink] afedulov opened a new pull request, #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

afedulov opened a new pull request, #20204:
URL: https://github.com/apache/flink/pull/20204

   The settings layout changed in the newer IntelliJ versions. This hotfix updates the docs to incorporate the up-to-date instructions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20204:
URL: https://github.com/apache/flink/pull/20204#discussion_r916837239


##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -149,6 +149,12 @@ It is recommended to automatically format your code by applying the following se
 8. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
 9. Under "File Path Inclusions", add an entry for `.*\.java` and `.*\.scala` to avoid formatting other file types.
 
+For IntelliJ IDEA version > 2021.2:
+
+6. Go to "Settings" → "Tools" → "Actions on Save".
+7. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
+8. From the "All file types list" next to "Reformat code", select Java and Scala.

Review Comment:
   In my 2021.3 it was missing. Let me update my IDE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on a diff in pull request #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

Posted by GitBox <gi...@apache.org>.
afedulov commented on code in PR #20204:
URL: https://github.com/apache/flink/pull/20204#discussion_r917437298


##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -149,6 +149,12 @@ It is recommended to automatically format your code by applying the following se
 8. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
 9. Under "File Path Inclusions", add an entry for `.*\.java` and `.*\.scala` to avoid formatting other file types.
 
+For IntelliJ IDEA version > 2021.2:
+
+6. Go to "Settings" → "Tools" → "Actions on Save".
+7. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
+8. From the "All file types list" next to "Reformat code", select Java and Scala.

Review Comment:
   @zentol I adjusted the version as proposed. I checked 2021.2 on both Linux and Mac and the Copyright feature is there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20204:
URL: https://github.com/apache/flink/pull/20204#issuecomment-1178242624

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "52b07b72d0010d3cec91a8a226916e0b15de31fc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "52b07b72d0010d3cec91a8a226916e0b15de31fc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 52b07b72d0010d3cec91a8a226916e0b15de31fc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20204:
URL: https://github.com/apache/flink/pull/20204#discussion_r916535118


##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -149,6 +149,12 @@ It is recommended to automatically format your code by applying the following se
 8. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
 9. Under "File Path Inclusions", add an entry for `.*\.java` and `.*\.scala` to avoid formatting other file types.
 
+For IntelliJ IDEA version > 2021.2:
+
+6. Go to "Settings" → "Tools" → "Actions on Save".
+7. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
+8. From the "All file types list" next to "Reformat code", select Java and Scala.

Review Comment:
   This is fine, but the list above that still mentions the old settings location.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

Posted by GitBox <gi...@apache.org>.
zentol merged PR #20204:
URL: https://github.com/apache/flink/pull/20204


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20204:
URL: https://github.com/apache/flink/pull/20204#discussion_r917605953


##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -149,6 +149,12 @@ It is recommended to automatically format your code by applying the following se
 8. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
 9. Under "File Path Inclusions", add an entry for `.*\.java` and `.*\.scala` to avoid formatting other file types.
 
+For IntelliJ IDEA version > 2021.2:
+
+6. Go to "Settings" → "Tools" → "Actions on Save".
+7. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
+8. From the "All file types list" next to "Reformat code", select Java and Scala.

Review Comment:
   I disabled this feature 🤦 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20204:
URL: https://github.com/apache/flink/pull/20204#discussion_r916535118


##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -149,6 +149,12 @@ It is recommended to automatically format your code by applying the following se
 8. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
 9. Under "File Path Inclusions", add an entry for `.*\.java` and `.*\.scala` to avoid formatting other file types.
 
+For IntelliJ IDEA version > 2021.2:
+
+6. Go to "Settings" → "Tools" → "Actions on Save".
+7. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
+8. From the "All file types list" next to "Reformat code", select Java and Scala.

Review Comment:
   This is fine, but the list above that still mentions the old settings location.
   
   I would move this up so it's listed first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20204:
URL: https://github.com/apache/flink/pull/20204#discussion_r916758185


##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -149,6 +149,12 @@ It is recommended to automatically format your code by applying the following se
 8. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
 9. Under "File Path Inclusions", add an entry for `.*\.java` and `.*\.scala` to avoid formatting other file types.
 
+For IntelliJ IDEA version > 2021.2:
+
+6. Go to "Settings" → "Tools" → "Actions on Save".
+7. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
+8. From the "All file types list" next to "Reformat code", select Java and Scala.

Review Comment:
   AFAICT the `Copyright Profile` doesn't work anymore; doesn't look like it was moved, maybe it was just superceded by file templates (which is what I use).
   
   For scala spotless takes care of license headers, which we could also enabled for java.
   
   The rest should be fine I think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20204:
URL: https://github.com/apache/flink/pull/20204#discussion_r916868414


##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -149,6 +149,12 @@ It is recommended to automatically format your code by applying the following se
 8. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
 9. Under "File Path Inclusions", add an entry for `.*\.java` and `.*\.scala` to avoid formatting other file types.
 
+For IntelliJ IDEA version > 2021.2:
+
+6. Go to "Settings" → "Tools" → "Actions on Save".
+7. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
+8. From the "All file types list" next to "Reformat code", select Java and Scala.

Review Comment:
   Not there for me in 2022.1.3 CE. So the guide may work as-is for later Ultimate versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on a diff in pull request #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

Posted by GitBox <gi...@apache.org>.
afedulov commented on code in PR #20204:
URL: https://github.com/apache/flink/pull/20204#discussion_r916748524


##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -149,6 +149,12 @@ It is recommended to automatically format your code by applying the following se
 8. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
 9. Under "File Path Inclusions", add an entry for `.*\.java` and `.*\.scala` to avoid formatting other file types.
 
+For IntelliJ IDEA version > 2021.2:
+
+6. Go to "Settings" → "Tools" → "Actions on Save".
+7. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
+8. From the "All file types list" next to "Reformat code", select Java and Scala.

Review Comment:
   I thought about doing it that way but there is an "umbrella" statement that the whole section is applicable to 2020.3. 
   https://github.com/afedulov/flink/blob/hotfix-intellij/docs/content/docs/flinkDev/ide_setup.md?plain=1#L65
   Do you know if the rest is applicable verbatim in the newer versions? Then we can bump that statement to 2021.2, move the new section up and the existing under the "For older IntelliJ version:" paragraph.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on a diff in pull request #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

Posted by GitBox <gi...@apache.org>.
afedulov commented on code in PR #20204:
URL: https://github.com/apache/flink/pull/20204#discussion_r916905260


##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -149,6 +149,12 @@ It is recommended to automatically format your code by applying the following se
 8. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
 9. Under "File Path Inclusions", add an entry for `.*\.java` and `.*\.scala` to avoid formatting other file types.
 
+For IntelliJ IDEA version > 2021.2:
+
+6. Go to "Settings" → "Tools" → "Actions on Save".
+7. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
+8. From the "All file types list" next to "Reformat code", select Java and Scala.

Review Comment:
   I had a copy of 2021.2 CE on my machine, the Copyright is there :thinking: 
   Checked 2022.1.3 CE - also available. :man_shrugging: 
   Maybe it is a Windows-specific issue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] afedulov commented on a diff in pull request #20204: [hotfix][docs] Update code formatting instructions for newer IntelliJ versions.

Posted by GitBox <gi...@apache.org>.
afedulov commented on code in PR #20204:
URL: https://github.com/apache/flink/pull/20204#discussion_r916787296


##########
docs/content/docs/flinkDev/ide_setup.md:
##########
@@ -149,6 +149,12 @@ It is recommended to automatically format your code by applying the following se
 8. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
 9. Under "File Path Inclusions", add an entry for `.*\.java` and `.*\.scala` to avoid formatting other file types.
 
+For IntelliJ IDEA version > 2021.2:
+
+6. Go to "Settings" → "Tools" → "Actions on Save".
+7. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
+8. From the "All file types list" next to "Reformat code", select Java and Scala.

Review Comment:
   Hmm...I am on 2022.1.3 and the Copyright works fine.
   
   ![image](https://user-images.githubusercontent.com/1492164/177995123-02ce78ca-54bf-4ab9-b9e6-fbb3bf9d1044.png)
   
   I am on Ultimate, but [this](https://www.jetbrains.com/help/idea/2022.1/copyright.html) page in the docs does not have the "Ultimate" tag, so it still must be available in the CE.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org