You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/09/23 20:17:33 UTC
[jira] Created: (LUCENE-2663) wrong exception from
NativeFSLockFactory (LIA2 test case)
wrong exception from NativeFSLockFactory (LIA2 test case)
---------------------------------------------------------
Key: LUCENE-2663
URL: https://issues.apache.org/jira/browse/LUCENE-2663
Project: Lucene - Java
Issue Type: Bug
Components: Index
Reporter: Robert Muir
Fix For: 3.1, 4.0
As part of integrating Lucene In Action 2 test cases (LUCENE-2661), I found one of the test cases fail
the test is pretty simple, and passes on 3.0. The exception you get instead (LockReleaseFailedException) is
pretty confusing and I think we should fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2663) wrong exception from
NativeFSLockFactory (LIA2 test case)
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914146#action_12914146 ]
Uwe Schindler commented on LUCENE-2663:
---------------------------------------
Sorry, you are right. The exception throws is clearly wrong :-) Maybe its related to Shai's changes in NativeFSLockFactory (which is the default)?
> wrong exception from NativeFSLockFactory (LIA2 test case)
> ---------------------------------------------------------
>
> Key: LUCENE-2663
> URL: https://issues.apache.org/jira/browse/LUCENE-2663
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2663_test.patch
>
>
> As part of integrating Lucene In Action 2 test cases (LUCENE-2661), I found one of the test cases fail
> the test is pretty simple, and passes on 3.0. The exception you get instead (LockReleaseFailedException) is
> pretty confusing and I think we should fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-2663) wrong exception from
NativeFSLockFactory (LIA2 test case)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-2663:
------------------------------------------
Assignee: Michael McCandless
> wrong exception from NativeFSLockFactory (LIA2 test case)
> ---------------------------------------------------------
>
> Key: LUCENE-2663
> URL: https://issues.apache.org/jira/browse/LUCENE-2663
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Robert Muir
> Assignee: Michael McCandless
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2663_test.patch
>
>
> As part of integrating Lucene In Action 2 test cases (LUCENE-2661), I found one of the test cases fail
> the test is pretty simple, and passes on 3.0. The exception you get instead (LockReleaseFailedException) is
> pretty confusing and I think we should fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2663) wrong exception from
NativeFSLockFactory (LIA2 test case)
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914141#action_12914141 ]
Uwe Schindler commented on LUCENE-2663:
---------------------------------------
May there be a randomization issue. If both index writers use a different LockFacory, it can easy fail! So at least for one test run, the LockFactory should be identical, else the locking can produce wrong failures/messages, as SimpleFSLock and NativeFSLock can interact very limited, but there are only some security checks, so locking will fail if you mix the implementations.
> wrong exception from NativeFSLockFactory (LIA2 test case)
> ---------------------------------------------------------
>
> Key: LUCENE-2663
> URL: https://issues.apache.org/jira/browse/LUCENE-2663
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2663_test.patch
>
>
> As part of integrating Lucene In Action 2 test cases (LUCENE-2661), I found one of the test cases fail
> the test is pretty simple, and passes on 3.0. The exception you get instead (LockReleaseFailedException) is
> pretty confusing and I think we should fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2663) wrong exception from
NativeFSLockFactory (LIA2 test case)
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914139#action_12914139 ]
Robert Muir commented on LUCENE-2663:
-------------------------------------
for trunk, just change the test to use MockAnalyzer instead of simple... i made the patch from 3x.
> wrong exception from NativeFSLockFactory (LIA2 test case)
> ---------------------------------------------------------
>
> Key: LUCENE-2663
> URL: https://issues.apache.org/jira/browse/LUCENE-2663
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2663_test.patch
>
>
> As part of integrating Lucene In Action 2 test cases (LUCENE-2661), I found one of the test cases fail
> the test is pretty simple, and passes on 3.0. The exception you get instead (LockReleaseFailedException) is
> pretty confusing and I think we should fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2663) wrong exception from
NativeFSLockFactory (LIA2 test case)
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914144#action_12914144 ]
Robert Muir commented on LUCENE-2663:
-------------------------------------
The test isnt random. it uses FSDirectory.open
> wrong exception from NativeFSLockFactory (LIA2 test case)
> ---------------------------------------------------------
>
> Key: LUCENE-2663
> URL: https://issues.apache.org/jira/browse/LUCENE-2663
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2663_test.patch
>
>
> As part of integrating Lucene In Action 2 test cases (LUCENE-2661), I found one of the test cases fail
> the test is pretty simple, and passes on 3.0. The exception you get instead (LockReleaseFailedException) is
> pretty confusing and I think we should fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2663) wrong exception from
NativeFSLockFactory (LIA2 test case)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917190#action_12917190 ]
Michael McCandless commented on LUCENE-2663:
--------------------------------------------
I think we should remove the call inside IW to dir.clearLock? This is a holdover from when SimpleFSLockFactory was the default. And, I think it's devious/dangerous w/ that lock factory since that lock factory lets you simply erase the lock out from under another open IW. Ie that call masks bugs.
All tests pass when I remove it, and, the LIA lock test also passes.
> wrong exception from NativeFSLockFactory (LIA2 test case)
> ---------------------------------------------------------
>
> Key: LUCENE-2663
> URL: https://issues.apache.org/jira/browse/LUCENE-2663
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2663_test.patch
>
>
> As part of integrating Lucene In Action 2 test cases (LUCENE-2661), I found one of the test cases fail
> the test is pretty simple, and passes on 3.0. The exception you get instead (LockReleaseFailedException) is
> pretty confusing and I think we should fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2663) wrong exception from
NativeFSLockFactory (LIA2 test case)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914160#action_12914160 ]
Michael McCandless commented on LUCENE-2663:
--------------------------------------------
I think it is the recent changes to NativeFSLockFactory...
IW tries to first clear the lock, if create=true, and that attempt is causing the exception. Really this is a holdover from SimpleFSLockFactory, which can leave orphan'd locks... so maybe somehow we shouldn't do this for other lock factories?
> wrong exception from NativeFSLockFactory (LIA2 test case)
> ---------------------------------------------------------
>
> Key: LUCENE-2663
> URL: https://issues.apache.org/jira/browse/LUCENE-2663
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2663_test.patch
>
>
> As part of integrating Lucene In Action 2 test cases (LUCENE-2661), I found one of the test cases fail
> the test is pretty simple, and passes on 3.0. The exception you get instead (LockReleaseFailedException) is
> pretty confusing and I think we should fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2663) wrong exception from
NativeFSLockFactory (LIA2 test case)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-2663.
----------------------------------------
Resolution: Fixed
> wrong exception from NativeFSLockFactory (LIA2 test case)
> ---------------------------------------------------------
>
> Key: LUCENE-2663
> URL: https://issues.apache.org/jira/browse/LUCENE-2663
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Robert Muir
> Assignee: Michael McCandless
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2663_test.patch
>
>
> As part of integrating Lucene In Action 2 test cases (LUCENE-2661), I found one of the test cases fail
> the test is pretty simple, and passes on 3.0. The exception you get instead (LockReleaseFailedException) is
> pretty confusing and I think we should fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2663) wrong exception from
NativeFSLockFactory (LIA2 test case)
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2663:
--------------------------------
Attachment: LUCENE-2663_test.patch
> wrong exception from NativeFSLockFactory (LIA2 test case)
> ---------------------------------------------------------
>
> Key: LUCENE-2663
> URL: https://issues.apache.org/jira/browse/LUCENE-2663
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2663_test.patch
>
>
> As part of integrating Lucene In Action 2 test cases (LUCENE-2661), I found one of the test cases fail
> the test is pretty simple, and passes on 3.0. The exception you get instead (LockReleaseFailedException) is
> pretty confusing and I think we should fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org