You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Yuval-Moshe (via GitHub)" <gi...@apache.org> on 2023/08/17 10:39:52 UTC
[GitHub] [superset] Yuval-Moshe commented on pull request #24999: fix(mssql): avoid trying to return a resultset for DML queries with not resultset
Yuval-Moshe commented on PR #24999:
URL: https://github.com/apache/superset/pull/24999#issuecomment-1682050918
Hi @john-bodley, sure no problem.
I've fixed the failing test be providing a mocked cursor instead of a None cursor, and added an additional unit test to test the no description scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org