You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2021/12/29 00:27:39 UTC
[GitHub] [jena] bvosburgh-tq opened a new pull request #1147: move RDFWriterRegistry static initialization block...
bvosburgh-tq opened a new pull request #1147:
URL: https://github.com/apache/jena/pull/1147
... so it executes after static fields are initialized
Since this not easy to test without starting a new JVM, a simple program demonstrates the problem:
```
import org.apache.jena.riot.RDFFormat;
import org.apache.jena.riot.RDFWriterRegistry;
import org.apache.jena.riot.WriterGraphRIOTFactory;
public class TestRDFWriterRegistry {
public static void main(String[] args) {
RDFWriterRegistry.register((RDFFormat) null, (WriterGraphRIOTFactory) null);
System.out.println("done");
}
}
```
Running the program will result in this exception:
```
Exception in thread "main" java.lang.ExceptionInInitializerError
at TestRDFWriterRegistry.main(TestRDFWriterRegistry.java:27)
Caused by: java.lang.NullPointerException: Cannot invoke "java.util.Map.put(Object, Object)" because "org.apache.jena.riot.RDFWriterRegistry.registryGraph" is null
at org.apache.jena.riot.RDFWriterRegistry.register(RDFWriterRegistry.java:224)
at org.apache.jena.riot.system.SysJSONLD11.init(SysJSONLD11.java:62)
at org.apache.jena.riot.RIOT.init(RIOT.java:84)
at org.apache.jena.riot.system.InitRIOT.start(InitRIOT.java:29)
at org.apache.jena.base.module.Subsystem.lambda$initialize$2(Subsystem.java:117)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at org.apache.jena.base.module.Subsystem.forEach(Subsystem.java:193)
at org.apache.jena.base.module.Subsystem.forEach(Subsystem.java:169)
at org.apache.jena.base.module.Subsystem.initialize(Subsystem.java:115)
at org.apache.jena.sys.JenaSystem.init(JenaSystem.java:88)
at org.apache.jena.riot.RDFWriterRegistry.<clinit>(RDFWriterRegistry.java:48)
... 1 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] bvosburgh-tq commented on pull request #1147: JENA-2243: Move RDFWriterRegistry static initialization block.
Posted by GitBox <gi...@apache.org>.
bvosburgh-tq commented on pull request #1147:
URL: https://github.com/apache/jena/pull/1147#issuecomment-1010673561
Yes, I could see the initialization gets complicated. : )
I ran into this NPE when I created some tests for a new implementation of `WriterGraphRIOT`. I wanted to simply register the writer and write some `Model`s. This seemed like an easy and maybe obvious fix to the NPE. My workaround was to add a call to `JenaSystem.init()` in the test setup; but that seemed like overkill for what are pretty simple, standalone-ish tests.
Anyway: thank you for merging this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1147: move RDFWriterRegistry static initialization block...
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #1147:
URL: https://github.com/apache/jena/pull/1147#issuecomment-1002537194
Out of curiosity - why is the first call to Jena at `RDFWriterRegistry`?
It is safer to explicitly call `JenaSystem.init` from the application before any Jena calls. This is the most tested and reliable approach. Ordering of Java class initialization gets pretty complicated quite quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1147: JENA-2243: Move RDFWriterRegistry static initialization block.
Posted by GitBox <gi...@apache.org>.
afs merged pull request #1147:
URL: https://github.com/apache/jena/pull/1147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org