You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/22 06:24:22 UTC
[GitHub] [superset] diegomedina248 opened a new pull request, #20819: fix: Temporal X Axis values are not properly displayed if the time column has a custom label defined
diegomedina248 opened a new pull request, #20819:
URL: https://github.com/apache/superset/pull/20819
### SUMMARY
Defining a label to the time column on the dataset level breaks the axis values displayed on the chart, in case the `GENERIC_CHART_AXES` feature flag enabled.
The issue is that, by changing the label, we're failing to calculate the proper type of the x axis column, since the dataType mapping is done with the original axis value.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://user-images.githubusercontent.com/17252075/180376109-403d63c4-c293-4af1-9cab-008332480965.mov
After:
https://user-images.githubusercontent.com/17252075/180376182-c5403433-df9c-4e50-8cbe-c017bbf47b29.mov
### TESTING INSTRUCTIONS
1. Create a **Bar Chart v2** using the `Vehicle Sales` dataset.
2. Set **Month** as the granularity.
3. Set `order_date` as the X Axis.
4. Set `sum(price_each)` as the metric.
5. Click on **CREATE CHART**.
6. Note that the months are properly displayed on the X Axis.
7. Click on the three ellipses next to the dataset name > **Edit dataset**.
8. Navigate to the **COLUMNS** tab.
9. Expand the `order_date` column.
10. Set date as a label for this column.
11. Click on **SAVE**.
12. Click on **OK**.
Ensure **Months** are still properly displayed on the X Axis.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #20819: fix: Temporal X Axis values are not properly displayed if the time column has a custom label defined
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged PR #20819:
URL: https://github.com/apache/superset/pull/20819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20819: fix: Temporal X Axis values are not properly displayed if the time column has a custom label defined
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20819:
URL: https://github.com/apache/superset/pull/20819#issuecomment-1192269820
# [Codecov](https://codecov.io/gh/apache/superset/pull/20819?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20819](https://codecov.io/gh/apache/superset/pull/20819?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (045352c) into [master](https://codecov.io/gh/apache/superset/commit/af1bddffad930efc0583b638716980db6747bfbc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af1bddf) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #20819 +/- ##
=======================================
Coverage 66.30% 66.30%
=======================================
Files 1758 1758
Lines 66802 66802
Branches 7056 7057 +1
=======================================
Hits 44294 44294
Misses 20710 20710
Partials 1798 1798
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.98% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...gin-chart-echarts/src/Timeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/20819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1Qcm9wcy50cw==) | `55.95% <100.00%> (ø)` | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] emgoryaynova commented on pull request #20819: fix: Temporal X Axis values are not properly displayed if the time column has a custom label defined
Posted by GitBox <gi...@apache.org>.
emgoryaynova commented on PR #20819:
URL: https://github.com/apache/superset/pull/20819#issuecomment-1255917699
Hi! I still have this issue in 2.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org