You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/09/28 14:39:34 UTC

[GitHub] [skywalking-banyandb] sacloudy opened a new pull request, #180: add measure and group cmd

sacloudy opened a new pull request, #180:
URL: https://github.com/apache/skywalking-banyandb/pull/180

   - add stream query test (failed to pass)
   - add measure cmd and test
   - add group cmd and test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #180: add measure and group cmd

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #180:
URL: https://github.com/apache/skywalking-banyandb/pull/180#issuecomment-1264942102

   # [Codecov](https://codecov.io/gh/apache/skywalking-banyandb/pull/180?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#180](https://codecov.io/gh/apache/skywalking-banyandb/pull/180?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f34c5e) into [main](https://codecov.io/gh/apache/skywalking-banyandb/commit/64b9f2ea25af768dd4e6c738ba8f097a0e961074?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (64b9f2e) will **increase** coverage by `1.23%`.
   > The diff coverage is `82.02%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             main     #180      +/-   ##
   ==========================================
   + Coverage   41.37%   42.60%   +1.23%     
   ==========================================
     Files          73       74       +1     
     Lines        6782     6935     +153     
   ==========================================
   + Hits         2806     2955     +149     
   - Misses       3716     3718       +2     
   - Partials      260      262       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking-banyandb/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [banyand/liaison/grpc/measure.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9saWFpc29uL2dycGMvbWVhc3VyZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [banyand/liaison/grpc/stream.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9saWFpc29uL2dycGMvc3RyZWFtLmdv) | `0.00% <0.00%> (ø)` | |
   | [bydbctl/internal/cmd/group.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnlkYmN0bC9pbnRlcm5hbC9jbWQvZ3JvdXAuZ28=) | `86.66% <88.00%> (+14.32%)` | :arrow_up: |
   | [bydbctl/internal/cmd/measure.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnlkYmN0bC9pbnRlcm5hbC9jbWQvbWVhc3VyZS5nbw==) | `88.23% <88.23%> (ø)` | |
   | [bydbctl/internal/cmd/rest.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnlkYmN0bC9pbnRlcm5hbC9jbWQvcmVzdC5nbw==) | `54.83% <100.00%> (+7.16%)` | :arrow_up: |
   | [bydbctl/internal/cmd/root.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnlkYmN0bC9pbnRlcm5hbC9jbWQvcm9vdC5nbw==) | `82.35% <100.00%> (ø)` | |
   | [bydbctl/internal/cmd/stream.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/180/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnlkYmN0bC9pbnRlcm5hbC9jbWQvc3RyZWFtLmdv) | `88.46% <100.00%> (+7.15%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/skywalking-banyandb/pull/180/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] hanahmily commented on pull request #180: add measure and group cmd

Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #180:
URL: https://github.com/apache/skywalking-banyandb/pull/180#issuecomment-1264968813

   @sacloudy Please add `start` and `end` flags to `query` commands.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] hanahmily merged pull request #180: add measure and group cmd

Posted by GitBox <gi...@apache.org>.
hanahmily merged PR #180:
URL: https://github.com/apache/skywalking-banyandb/pull/180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org