You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/27 10:54:17 UTC
[GitHub] [shardingsphere] soulasuna opened a new pull request #15122: Type case completed in integration test
soulasuna opened a new pull request #15122:
URL: https://github.com/apache/shardingsphere/pull/15122
## Type case completed in integration test
Related to #14899
Changes proposed in this pull request:
- Add `SMALLINT` type case in integration test.
- Add `BOOLEAN` type case in integration test.
- Add `ENUM` type case in integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN merged pull request #15122: Type case completed in integration test
Posted by GitBox <gi...@apache.org>.
TeslaCN merged pull request #15122:
URL: https://github.com/apache/shardingsphere/pull/15122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #15122: Type case completed in integration test
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #15122:
URL: https://github.com/apache/shardingsphere/pull/15122#discussion_r793498975
##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-fixture/src/test/java/org/apache/shardingsphere/test/integration/cases/assertion/IntegrationTestCaseAssertion.java
##########
@@ -65,9 +66,26 @@
Collection<SQLValue> result = new LinkedList<>();
int count = 0;
for (String each : Splitter.on(",").trimResults().splitToList(parameters)) {
- List<String> parameterPair = Splitter.on(":").trimResults().splitToList(each);
+ List<String> parameterPair = parseParameter(each);
result.add(new SQLValue(parameterPair.get(0), parameterPair.get(1), ++count));
}
return result;
}
+
+ private List<String> parseParameter(final String each) {
Review comment:
The parameter `each` is hard to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] soulasuna commented on a change in pull request #15122: Type case completed in integration test
Posted by GitBox <gi...@apache.org>.
soulasuna commented on a change in pull request #15122:
URL: https://github.com/apache/shardingsphere/pull/15122#discussion_r793515484
##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-fixture/src/test/java/org/apache/shardingsphere/test/integration/cases/assertion/IntegrationTestCaseAssertion.java
##########
@@ -65,9 +66,26 @@
Collection<SQLValue> result = new LinkedList<>();
int count = 0;
for (String each : Splitter.on(",").trimResults().splitToList(parameters)) {
- List<String> parameterPair = Splitter.on(":").trimResults().splitToList(each);
+ List<String> parameterPair = parseParameter(each);
result.add(new SQLValue(parameterPair.get(0), parameterPair.get(1), ++count));
}
return result;
}
+
+ private List<String> parseParameter(final String each) {
Review comment:
I will rename it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org