You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2012/11/27 12:02:00 UTC
[jira] [Commented] (BOOKKEEPER-477) In ReadOnlyBookieTest, we
should wait for the bookie to die before asserting on it
[ https://issues.apache.org/jira/browse/BOOKKEEPER-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504532#comment-13504532 ]
Flavio Junqueira commented on BOOKKEEPER-477:
---------------------------------------------
We might have discussed this in the past, but isn't there perhaps a more reliable way of detecting that a bookie has shut down? Using time is prone to false positives and often increases the time to run tests.
> In ReadOnlyBookieTest, we should wait for the bookie to die before asserting on it
> ----------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-477
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-477
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0002-ReadOnlyBookieTest-Give-the-bookie-a-chance-to-die.patch
>
>
> Right now we assert immediately, so the bookie thread has no chance to die. We should only assert after giving it a chance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira