You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/01/18 11:30:43 UTC
Review Request 42454: LENS-926 : Fixes Chain ref column from bridge
table to be resolved correctly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42454/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-926
https://issues.apache.org/jira/browse/LENS-926
Repository: lens
Description
-------
Fix is to add the column as queried from column from the alias, sothat bridge table resolution puts the join correctly.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java c83b9ac
lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 4c30d3f
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java caea3af
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java PRE-CREATION
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 698f36c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 2cf92b9
Diff: https://reviews.apache.org/r/42454/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.588s]
[INFO] Lens .............................................. SUCCESS [3.248s]
[INFO] Lens API .......................................... SUCCESS [27.261s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.279s]
[INFO] Lens Cube ......................................... SUCCESS [11:17.004s]
[INFO] Lens DB storage ................................... SUCCESS [19.111s]
[INFO] Lens Query Library ................................ SUCCESS [17.350s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.857s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.020s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [16.754s]
[INFO] Lens Server ....................................... SUCCESS [10:03.654s]
[INFO] Lens client ....................................... SUCCESS [35.201s]
[INFO] Lens CLI .......................................... SUCCESS [54.474s]
[INFO] Lens Examples ..................................... SUCCESS [9.045s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.893s]
[INFO] Lens Distribution ................................. SUCCESS [8.084s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.132s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.056s]
[INFO] Lens Regression ................................... SUCCESS [14.848s]
[INFO] Lens UI ........................................... SUCCESS [28.522s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:30.330s
[INFO] Finished at: Mon Jan 18 10:29:12 UTC 2016
[INFO] Final Memory: 193M/1904M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 42454: LENS-926 : Fixes Chain ref column from
bridge table to be resolved correctly
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42454/#review115607
-----------------------------------------------------------
Ship it!
Ship It!
- Sushil Mohanty
On Jan. 21, 2016, 4:34 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42454/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 4:34 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-926
> https://issues.apache.org/jira/browse/LENS-926
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fix is to add the column as queried from column from the alias, sothat bridge table resolution puts the join correctly.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java c83b9ac
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 4c30d3f
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java caea3af
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 698f36c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 2cf92b9
>
> Diff: https://reviews.apache.org/r/42454/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.588s]
> [INFO] Lens .............................................. SUCCESS [3.248s]
> [INFO] Lens API .......................................... SUCCESS [27.261s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.279s]
> [INFO] Lens Cube ......................................... SUCCESS [11:17.004s]
> [INFO] Lens DB storage ................................... SUCCESS [19.111s]
> [INFO] Lens Query Library ................................ SUCCESS [17.350s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.857s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.020s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.754s]
> [INFO] Lens Server ....................................... SUCCESS [10:03.654s]
> [INFO] Lens client ....................................... SUCCESS [35.201s]
> [INFO] Lens CLI .......................................... SUCCESS [54.474s]
> [INFO] Lens Examples ..................................... SUCCESS [9.045s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.893s]
> [INFO] Lens Distribution ................................. SUCCESS [8.084s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.132s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.056s]
> [INFO] Lens Regression ................................... SUCCESS [14.848s]
> [INFO] Lens UI ........................................... SUCCESS [28.522s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:30.330s
> [INFO] Finished at: Mon Jan 18 10:29:12 UTC 2016
> [INFO] Final Memory: 193M/1904M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 42454: LENS-926 : Fixes Chain ref column from
bridge table to be resolved correctly
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42454/
-----------------------------------------------------------
(Updated Jan. 21, 2016, 4:34 a.m.)
Review request for lens.
Changes
-------
Review comments fixed
Bugs: LENS-926
https://issues.apache.org/jira/browse/LENS-926
Repository: lens
Description
-------
Fix is to add the column as queried from column from the alias, sothat bridge table resolution puts the join correctly.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java c83b9ac
lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 4c30d3f
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java caea3af
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java PRE-CREATION
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 698f36c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 2cf92b9
Diff: https://reviews.apache.org/r/42454/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.588s]
[INFO] Lens .............................................. SUCCESS [3.248s]
[INFO] Lens API .......................................... SUCCESS [27.261s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.279s]
[INFO] Lens Cube ......................................... SUCCESS [11:17.004s]
[INFO] Lens DB storage ................................... SUCCESS [19.111s]
[INFO] Lens Query Library ................................ SUCCESS [17.350s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.857s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.020s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [16.754s]
[INFO] Lens Server ....................................... SUCCESS [10:03.654s]
[INFO] Lens client ....................................... SUCCESS [35.201s]
[INFO] Lens CLI .......................................... SUCCESS [54.474s]
[INFO] Lens Examples ..................................... SUCCESS [9.045s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.893s]
[INFO] Lens Distribution ................................. SUCCESS [8.084s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.132s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.056s]
[INFO] Lens Regression ................................... SUCCESS [14.848s]
[INFO] Lens UI ........................................... SUCCESS [28.522s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:30.330s
[INFO] Finished at: Mon Jan 18 10:29:12 UTC 2016
[INFO] Final Memory: 193M/1904M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 42454: LENS-926 : Fixes Chain ref column from
bridge table to be resolved correctly
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Jan. 20, 2016, 5:39 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java, line 33
> > <https://reviews.apache.org/r/42454/diff/1/?file=1200016#file1200016line33>
> >
> > Other than moving from the other class, any changes here?
Updated all tests to run with chain ref column fields.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42454/#review115351
-----------------------------------------------------------
On Jan. 18, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42454/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 10:30 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-926
> https://issues.apache.org/jira/browse/LENS-926
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fix is to add the column as queried from column from the alias, sothat bridge table resolution puts the join correctly.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java c83b9ac
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 4c30d3f
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java caea3af
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 698f36c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 2cf92b9
>
> Diff: https://reviews.apache.org/r/42454/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.588s]
> [INFO] Lens .............................................. SUCCESS [3.248s]
> [INFO] Lens API .......................................... SUCCESS [27.261s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.279s]
> [INFO] Lens Cube ......................................... SUCCESS [11:17.004s]
> [INFO] Lens DB storage ................................... SUCCESS [19.111s]
> [INFO] Lens Query Library ................................ SUCCESS [17.350s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.857s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.020s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.754s]
> [INFO] Lens Server ....................................... SUCCESS [10:03.654s]
> [INFO] Lens client ....................................... SUCCESS [35.201s]
> [INFO] Lens CLI .......................................... SUCCESS [54.474s]
> [INFO] Lens Examples ..................................... SUCCESS [9.045s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.893s]
> [INFO] Lens Distribution ................................. SUCCESS [8.084s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.132s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.056s]
> [INFO] Lens Regression ................................... SUCCESS [14.848s]
> [INFO] Lens UI ........................................... SUCCESS [28.522s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:30.330s
> [INFO] Finished at: Mon Jan 18 10:29:12 UTC 2016
> [INFO] Final Memory: 193M/1904M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 42454: LENS-926 : Fixes Chain ref column from
bridge table to be resolved correctly
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42454/#review115351
-----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java (line 33)
<https://reviews.apache.org/r/42454/#comment176331>
Other than moving from the other class, any changes here?
- Rajat Khandelwal
On Jan. 18, 2016, 4 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42454/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 4 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-926
> https://issues.apache.org/jira/browse/LENS-926
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fix is to add the column as queried from column from the alias, sothat bridge table resolution puts the join correctly.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java c83b9ac
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 4c30d3f
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java caea3af
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 698f36c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 2cf92b9
>
> Diff: https://reviews.apache.org/r/42454/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.588s]
> [INFO] Lens .............................................. SUCCESS [3.248s]
> [INFO] Lens API .......................................... SUCCESS [27.261s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.279s]
> [INFO] Lens Cube ......................................... SUCCESS [11:17.004s]
> [INFO] Lens DB storage ................................... SUCCESS [19.111s]
> [INFO] Lens Query Library ................................ SUCCESS [17.350s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.857s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.020s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.754s]
> [INFO] Lens Server ....................................... SUCCESS [10:03.654s]
> [INFO] Lens client ....................................... SUCCESS [35.201s]
> [INFO] Lens CLI .......................................... SUCCESS [54.474s]
> [INFO] Lens Examples ..................................... SUCCESS [9.045s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.893s]
> [INFO] Lens Distribution ................................. SUCCESS [8.084s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.132s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.056s]
> [INFO] Lens Regression ................................... SUCCESS [14.848s]
> [INFO] Lens UI ........................................... SUCCESS [28.522s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:30.330s
> [INFO] Finished at: Mon Jan 18 10:29:12 UTC 2016
> [INFO] Final Memory: 193M/1904M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 42454: LENS-926 : Fixes Chain ref column from
bridge table to be resolved correctly
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42454/#review115145
-----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java (line 50)
<https://reviews.apache.org/r/42454/#comment176031>
redundant? Already defined in @BeforeTest
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java (line 72)
<https://reviews.apache.org/r/42454/#comment176032>
Can you remove it from all test methods if it is redundant?
- Raju Bairishetti
On Jan. 18, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42454/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 10:30 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-926
> https://issues.apache.org/jira/browse/LENS-926
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fix is to add the column as queried from column from the alias, sothat bridge table resolution puts the join correctly.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java c83b9ac
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 4c30d3f
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java caea3af
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 698f36c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 2cf92b9
>
> Diff: https://reviews.apache.org/r/42454/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.588s]
> [INFO] Lens .............................................. SUCCESS [3.248s]
> [INFO] Lens API .......................................... SUCCESS [27.261s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.279s]
> [INFO] Lens Cube ......................................... SUCCESS [11:17.004s]
> [INFO] Lens DB storage ................................... SUCCESS [19.111s]
> [INFO] Lens Query Library ................................ SUCCESS [17.350s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.857s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.020s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.754s]
> [INFO] Lens Server ....................................... SUCCESS [10:03.654s]
> [INFO] Lens client ....................................... SUCCESS [35.201s]
> [INFO] Lens CLI .......................................... SUCCESS [54.474s]
> [INFO] Lens Examples ..................................... SUCCESS [9.045s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.893s]
> [INFO] Lens Distribution ................................. SUCCESS [8.084s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.132s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.056s]
> [INFO] Lens Regression ................................... SUCCESS [14.848s]
> [INFO] Lens UI ........................................... SUCCESS [28.522s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:30.330s
> [INFO] Finished at: Mon Jan 18 10:29:12 UTC 2016
> [INFO] Final Memory: 193M/1904M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>