You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/10 14:02:10 UTC

[GitHub] [spark] LuciferYang opened a new pull request, #36133: [SPARK-38848][TESTS] Replcace all `@Test(expected = XXException)` with `assertThrows`

LuciferYang opened a new pull request, #36133:
URL: https://github.com/apache/spark/pull/36133

   ### What changes were proposed in this pull request?
   `@Test` no longer has `expected` parameters in Junit 5, this pr replace them with `assertThrows` to reduce the workload of future migration from Junit 4 to Junit 5. 
   
   
   ### Why are the changes needed?
   Reduce Api usage that JUnit 5 no longer supports.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Pass GA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen closed pull request #36133: [SPARK-38848][TESTS] Replcace all `@Test(expected = XXException)` with `assertThrows`

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #36133: [SPARK-38848][TESTS] Replcace all `@Test(expected = XXException)` with `assertThrows`
URL: https://github.com/apache/spark/pull/36133


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #36133: [SPARK-38848][TESTS] Replcace all `@Test(expected = XXException)` with `assertThrows`

Posted by GitBox <gi...@apache.org>.
srowen commented on PR #36133:
URL: https://github.com/apache/spark/pull/36133#issuecomment-1096798640

   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #36133: [SPARK-38848][TESTS] Replcace all `@Test(expected = XXException)` with `assertThrows`

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #36133:
URL: https://github.com/apache/spark/pull/36133#issuecomment-1096800719

   thanks @srowen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org