[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1492: MINIFICPP-2021 Auto-generate extra doc sections in PROCESSORS.md

["martinzink (via GitHub)" <gi...@apache.org>]

martinzink commented on code in PR #1492:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1492#discussion_r1105984874


##########
minifi_main/AgentDocs.cpp:
##########
@@ -43,27 +81,17 @@ void AgentDocs::generate(const std::filesystem::path& docsdir, std::ostream &gen
   std::map<std::string, ClassDescription> processorSet;
   for (const auto &group : minifi::AgentBuild::getExtensions()) {
     struct Components descriptions = build_description_.getClassDescriptions(group);
-    for (const auto &processorName : descriptions.processors_) {
-      processorSet.insert(std::make_pair(extractClassName(processorName.full_name_), processorName));
+    for (const auto& processor_description : descriptions.processors_) {
+      processorSet.insert(std::make_pair(extractClassName(processor_description.full_name_), processor_description));
     }
   }
   for (const auto &processor : processorSet) {
     const auto& filename = docsdir / processor.first;

Review Comment:
   I think we could also add the .md extension to these files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org