You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/07/04 15:31:00 UTC
[jira] [Commented] (AIRFLOW-1321) 'Hide sensitive variable fields'
feature doesn't works if key is uppercase.
[ https://issues.apache.org/jira/browse/AIRFLOW-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073823#comment-16073823 ]
ASF subversion and git services commented on AIRFLOW-1321:
----------------------------------------------------------
Commit 46204606e3655a4b0785c1bca19a51b9a451a2eb in incubator-airflow's branch refs/heads/master from [~sekikn]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=4620460 ]
[AIRFLOW-1321] Fix hidden field key to ignore case
Webserver has a feature to hide sensitive variable fields,
which key contain specific words. But its matching is
case-sensitive, so "google_api_key" is hidden but
"GOOGLE_API_KEY" is not. This behaviour is not intuitive,
so this PR fixes it to be case-insensitive.
> 'Hide sensitive variable fields' feature doesn't works if key is uppercase.
> ---------------------------------------------------------------------------
>
> Key: AIRFLOW-1321
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1321
> Project: Apache Airflow
> Issue Type: Improvement
> Affects Versions: Airflow 1.8
> Reporter: Beomjun Kang
> Assignee: Kengo Seki
> Attachments: screenshot.png
>
>
> I tried to put key as uppercase like 'GOOGLE_API_KEY'. but it doesn't work as I expected.
> So, I changed key like 'GOOGLE_api_key'. Finally, it works.
> (Please see the attachment)
> This doesn't make sense to me.
> How about using case insensitive comparison for checking?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)