You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.com> on 2017/01/25 00:24:03 UTC
Review Request 55899: Renamed `taskID` to `taskId` in `HealthChecker`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55899/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
Bugs: MESOS-6280
https://issues.apache.org/jira/browse/MESOS-6280
Repository: mesos
Description
-------
We normally use `taskId` for variables that hold a `TaskID`, so I
renamed the attribute/parameters to be consistent with the rest of the
codebase.
Diffs
-----
src/checks/health_checker.hpp 6e558f2061a9e31157c47d31cb64b3a8568aace3
src/checks/health_checker.cpp 50aa2858e807b27bbab58a3618f5200cfe4eca9e
Diff: https://reviews.apache.org/r/55899/diff/
Testing
-------
`make check` (macOS and Linux)
Thanks,
Gast�n Kleiman
Re: Review Request 55899: Renamed `taskID` to `taskId` in
`HealthChecker`.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55899/#review162985
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Jan. 25, 2017, 12:24 a.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55899/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2017, 12:24 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6280
> https://issues.apache.org/jira/browse/MESOS-6280
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We normally use `taskId` for variables that hold a `TaskID`, so I
> renamed the attribute/parameters to be consistent with the rest of the
> codebase.
>
>
> Diffs
> -----
>
> src/checks/health_checker.hpp 6e558f2061a9e31157c47d31cb64b3a8568aace3
> src/checks/health_checker.cpp 50aa2858e807b27bbab58a3618f5200cfe4eca9e
>
> Diff: https://reviews.apache.org/r/55899/diff/
>
>
> Testing
> -------
>
> `make check` (macOS and Linux)
>
>
> Thanks,
>
> Gast�n Kleiman
>
>