You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Hongchao Deng (JIRA)" <ji...@apache.org> on 2014/07/21 18:46:40 UTC

[jira] [Created] (ZOOKEEPER-1981) Fix Dodgy code Warnings

Hongchao Deng created ZOOKEEPER-1981:
----------------------------------------

             Summary: Fix Dodgy code Warnings
                 Key: ZOOKEEPER-1981
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1981
             Project: ZooKeeper
          Issue Type: Sub-task
            Reporter: Hongchao Deng
            Assignee: Hongchao Deng
            Priority: Minor


There are two cases:
1. a duplicate check of null bytes.
2. a lot switch statement without default case.

For the default case, I suggest 
1. throwing an exception as a way to break the program. It's highly unexpected. 
2. or LOG.warn it.

I am doing the second right now to keep the original.



--
This message was sent by Atlassian JIRA
(v6.2#6252)