[GitHub] [netbeans] neilcsmith-net commented on pull request #2778: Restore original format of m2:/ URLs modified by aa256463dcefb3b95bec6b7ac74e04a960015bc9

[GitBox <gi...@apache.org>]

neilcsmith-net commented on pull request #2778:
URL: https://github.com/apache/netbeans/pull/2778#issuecomment-784967142


   +1 to this (and/or -1 to #2777 )
   
   > but then I decided to prefer using the same format for binaries-files as well as m2:/.
   
   I don't understand this.  `m2:/` had a format?  eg. as specified at https://github.com/apache/netbeans/blob/master/java/maven.embedder/src/org/netbeans/modules/maven/embedder/impl/MavenProtocolHandler.java and (later) by https://github.com/apache/netbeans/blob/master/platform/core.startup/src/org/netbeans/core/startup/MavenRepoURLHandler.java
   
   > a new ad-hoc parser is introduced to convert the m2 URL into maven coordinates.
   
   Well, I guess would be nice if it wasn't parsed in slightly different ways in multiple places, but I'm not sure there's a way around that?!  Then again, shame we're not using an external format like Package URL too ... :shrug: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists