You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@helix.apache.org by GitBox <gi...@apache.org> on 2019/07/17 18:13:47 UTC

[GitHub] [helix] narendly commented on issue #340: Log the enqueue time of clusterEvent, used to measure the blocking qu…

narendly commented on issue #340: Log the enqueue time of clusterEvent, used to measure the blocking qu…
URL: https://github.com/apache/helix/pull/340#issuecomment-512508441
 
 
   I'm afraid this might overwhelm the log? Would be fine to do this in a testing environment where load is simulated, but in production, this may cause log files to grow too fast, especially in situations where the events are queued up (signalling there are many pending cluster changes to be dealt with).
   
   Hunter
   
   ⁣Sent from BlueMail 
   
   On Jul 17, 2019, 20:01, at 20:01, Yi Wang <no...@github.com> wrote:
   >When investigating the prod issue, I found now it lacks logs of when a
   >ClusterEvent gets pushed into the queue. I've added the simple log here
   >so that we would be able to measure the blocking queue processing speed
   >for an event.
   >You can view, comment on, or merge this pull request online at:
   >
   >  https://github.com/apache/helix/pull/340
   >
   >-- Commit Summary --
   >
   >* Log the enqueue time of clusterEvent, used to measure the blocking
   >queue processing speed
   >
   >-- File Changes --
   >
   >M
   >helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
   >(1)
   >
   >-- Patch Links --
   >
   >https://github.com/apache/helix/pull/340.patch
   >https://github.com/apache/helix/pull/340.diff
   >
   >-- 
   >You are receiving this because you are subscribed to this thread.
   >Reply to this email directly or view it on GitHub:
   >https://github.com/apache/helix/pull/340
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services