You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Jun Liu <li...@apache.org> on 2018/07/26 09:48:53 UTC

[VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Hello Dubbo Community,

This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.

The release candidates (RC1):
https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3

Git tag for the release (RC1):
https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3

Hash for the release tag:
a8be0eaaddab198ed03b0150d4db03e2b22f023f

Release Notes:
https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md

The artifacts have been signed with Key : 28681CB1, which can be found in the keys file:
https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS

The vote will be open for at least 72 hours or until necessary number of votes are reached.

Please vote accordingly:

[ ] +1 approve 
[ ] +0 no opinion 
[ ] -1 disapprove with the reason

Thanks,
The Apache Dubbo (Incubating) Team


Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by jun liu <ke...@gmail.com>.
Thanks for your attention.

We’ll appreciate it if you guys can help verifying the candidates in more depth and let us know which part you have checked and whether you think it’s ready for release or not.

Best regards,
Jun

> On 26 Jul 2018, at 17:54, yuhang xiu <ca...@gmail.com> wrote:
> 
> +1 approve
> 
> Look nice :)
> 
> 2018-07-26 17:48 GMT+08:00 Jun Liu <li...@apache.org>:
> 
>> Hello Dubbo Community,
>> 
>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
>> 
>> The release candidates (RC1):
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>> 
>> Git tag for the release (RC1):
>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>> 
>> Hash for the release tag:
>> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>> 
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md
>> 
>> The artifacts have been signed with Key : 28681CB1, which can be found in
>> the keys file:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>> 
>> The vote will be open for at least 72 hours or until necessary number of
>> votes are reached.
>> 
>> Please vote accordingly:
>> 
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>> 
>> Thanks,
>> The Apache Dubbo (Incubating) Team
>> 
>> 


Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by zhenya Sun <to...@126.com>.
+1





from my iphone!
On 07/26/2018 17:54, yuhang xiu wrote:
+1 approve

Look nice :)

2018-07-26 17:48 GMT+08:00 Jun Liu <li...@apache.org>:

> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
>
> The release candidates (RC1):
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>
> Git tag for the release (RC1):
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>
> Hash for the release tag:
> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>
> Release Notes:
> https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md
>
> The artifacts have been signed with Key : 28681CB1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team
>
>

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by yuhang xiu <ca...@gmail.com>.
+1 approve

Look nice :)

2018-07-26 17:48 GMT+08:00 Jun Liu <li...@apache.org>:

> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
>
> The release candidates (RC1):
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>
> Git tag for the release (RC1):
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>
> Hash for the release tag:
> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>
> Release Notes:
> https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md
>
> The artifacts have been signed with Key : 28681CB1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team
>
>

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by jun liu <ke...@gmail.com>.
Hi, all

I am canceling this vote and preparing for a new release candidate RC2. Huxing has found that the release candidates of RC1 contains a binary jar file, which is ./.mvn/wrapper/maven-wrapper.jar.

To summary the vote result this round:
+1 (non-binding), Yuhang Xiu
+1 (non-binding), Zhenya Sun
+1 (non-binding), leyou240@live.cn
-1 (binding), Huxing Zhang 

Best regards,
Jun

> On 29 Jul 2018, at 16:14, Huxing Zhang <hu...@apache.org> wrote:
> 
> Hi,
> 
> I think I found an issue that may need to rebuild the release candidate.
> 
> The source release contains a binary:
> 
> ./.mvn/wrapper/maven-wrapper.jar
> 
> Actually I run `mvn verify -Drat.skip=false`, as a result it found the
> archive in target/rat.txt but did not fail.
> 
> Notes: 3
> Binaries: 0
> Archives: 1
> Standards: 3
> 
> Apache Licensed: 3
> Generated Documents: 0
> 
> JavaDocs are generated, thus a license header is optional.
> Generated files do not require license headers.
> 
> 0 Unknown Licenses
> 
> Archives:
> 
> + .mvn/wrapper/maven-wrapper.jar
> 
> Previous discussion:
> https://lists.apache.org/thread.html/491ecd01802c48df8d906548e1d1db188c39a9546f958e834198d276@%3Cdev.dubbo.apache.org%3E
> 
> 
> Other details:
> 
> * incubator in name
> * Disclaimer exists
> * sha512 chesum ok
> * signature ok
> * git tag matches
> * NOTICE and LICENSE exist in META-INF of jar files of binary release.
> * Unit test passed on Java 8 + OSX
> * Tested elegant shutdown with Tomcat 8.5.30
> 
> Minor issues:
> * There are some typo in CHANGES.md, I saw it fixed in 2.6.3 release
> branch, but not included in the release candidate.
> 
> On Thu, Jul 26, 2018 at 5:48 PM, Jun Liu <li...@apache.org> wrote:
>> Hello Dubbo Community,
>> 
>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
>> 
>> The release candidates (RC1):
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>> 
>> Git tag for the release (RC1):
>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>> 
>> Hash for the release tag:
>> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>> 
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md
>> 
>> The artifacts have been signed with Key : 28681CB1, which can be found in the keys file:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>> 
>> The vote will be open for at least 72 hours or until necessary number of votes are reached.
>> 
>> Please vote accordingly:
>> 
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>> 
>> Thanks,
>> The Apache Dubbo (Incubating) Team
>> 
> 
> -- 
> Best Regards!
> Huxing


Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by Jun Liu <li...@apache.org>.
Awesome! This will surely help us to prepare for the following releases.
Thanks

Best regards,
Jun

> On 30 Jul 2018, at 20:02, Andrea Del Bene <an...@gmail.com> wrote:
> 
> Hi,
> 
> if you want to create a script to automate the release process you might find helpful the release script we use in Wicket. It performs different tasks but you can go straight to line 525 (https://github.com/apache/wicket/blob/master/release.sh#L525) where you can find some script code to generate sha signature, commit archives to svn etc...
> 
> 
> On 30/07/2018 12:05, jun liu wrote:
>> Hi, Andrea
>> 
>> We mainly use ’release-plugin’ to prepare for a release: upgrade pom version, package release candidate and deploy to maven central repo. Some processes are done manually, for example, 'generate sha512' and 'svn commit’.
>> You have mentioned a good point, I think we can use a .sh script to make the whole process done automatically.
>> 
>> Best regards,
>> Jun
>> 
>>> On 30 Jul 2018, at 15:14, Andrea Del Bene <an...@gmail.com> wrote:
>>> 
>>> Hi Jun,
>>> 
>>> just curious, is there a particular script or tool you use to build the
>>> releases?
>>> 
>>> Thank you.
>>> 
>>> On Mon, Jul 30, 2018 at 4:11 AM, Yong Zhu <di...@gmail.com> wrote:
>>> 
>>>> The source dir unzipped from the source zip is named
>>>> 'incubator-dubbo-dubbo-2.6.3'. Here `dubbo` is duplicated.
>>>> 
>>>> Is this intentional?
>>>> 
>>>> On Mon, Jul 30, 2018 at 10:06 AM Jun Liu <li...@apache.org> wrote:
>>>> 
>>>>>> I think I found an issue that may need to rebuild the release
>>>> candidate.
>>>>>> The source release contains a binary:
>>>>>> 
>>>>>> ./.mvn/wrapper/maven-wrapper.jar
>>>>> Yes, you are right, I have just checked and found the binary in the exact
>>>>> position.
>>>>> We can start the rebuild today.
>>>>> 
>>>>> I failed to notice that the rat and style plugin are closed by default
>>>>> when building the release candidate locally, I will open them in the next
>>>>> RC, they can help to check this kind of problems.
>>>>> 
>>>>> Best regards,
>>>>> Jun
>>>>> 
>>>>>> On 29 Jul 2018, at 16:14, Huxing Zhang <hu...@apache.org> wrote:
>>>>>> 
>>>>>> Hi,
>>>>>> 
>>>>>> I think I found an issue that may need to rebuild the release
>>>> candidate.
>>>>>> The source release contains a binary:
>>>>>> 
>>>>>> ./.mvn/wrapper/maven-wrapper.jar
>>>>>> 
>>>>>> Actually I run `mvn verify -Drat.skip=false`, as a result it found the
>>>>>> archive in target/rat.txt but did not fail.
>>>>>> 
>>>>>> Notes: 3
>>>>>> Binaries: 0
>>>>>> Archives: 1
>>>>>> Standards: 3
>>>>>> 
>>>>>> Apache Licensed: 3
>>>>>> Generated Documents: 0
>>>>>> 
>>>>>> JavaDocs are generated, thus a license header is optional.
>>>>>> Generated files do not require license headers.
>>>>>> 
>>>>>> 0 Unknown Licenses
>>>>>> 
>>>>>> Archives:
>>>>>> 
>>>>>> + .mvn/wrapper/maven-wrapper.jar
>>>>>> 
>>>>>> Previous discussion:
>>>>>> 
>>>>> https://lists.apache.org/thread.html/491ecd01802c48df8d906548e1d1db
>>>> 188c39a9546f958e834198d276@%3Cdev.dubbo.apache.org%3E
>>>>>> 
>>>>>> Other details:
>>>>>> 
>>>>>> * incubator in name
>>>>>> * Disclaimer exists
>>>>>> * sha512 chesum ok
>>>>>> * signature ok
>>>>>> * git tag matches
>>>>>> * NOTICE and LICENSE exist in META-INF of jar files of binary release.
>>>>>> * Unit test passed on Java 8 + OSX
>>>>>> * Tested elegant shutdown with Tomcat 8.5.30
>>>>>> 
>>>>>> Minor issues:
>>>>>> * There are some typo in CHANGES.md, I saw it fixed in 2.6.3 release
>>>>>> branch, but not included in the release candidate.
>>>>>> 
>>>>>> On Thu, Jul 26, 2018 at 5:48 PM, Jun Liu <li...@apache.org> wrote:
>>>>>>> Hello Dubbo Community,
>>>>>>> 
>>>>>>> This is a call for vote to release Apache Dubbo (Incubating) version
>>>>> 2.6.3.
>>>>>>> The release candidates (RC1):
>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>>>>>>> 
>>>>>>> Git tag for the release (RC1):
>>>>>>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>>>>>>> 
>>>>>>> Hash for the release tag:
>>>>>>> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>>>>>>> 
>>>>>>> Release Notes:
>>>>>>> https://github.com/apache/incubator-dubbo/blob/2.6.3-
>>>> release/CHANGES.md
>>>>>>> The artifacts have been signed with Key : 28681CB1, which can be found
>>>>> in the keys file:
>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>>>>>>> 
>>>>>>> The vote will be open for at least 72 hours or until necessary number
>>>>> of votes are reached.
>>>>>>> Please vote accordingly:
>>>>>>> 
>>>>>>> [ ] +1 approve
>>>>>>> [ ] +0 no opinion
>>>>>>> [ ] -1 disapprove with the reason
>>>>>>> 
>>>>>>> Thanks,
>>>>>>> The Apache Dubbo (Incubating) Team
>>>>>>> 
>>>>>> --
>>>>>> Best Regards!
>>>>>> Huxing
>>>>> 
>>> 
>>> 
>>> -- 
>>> Andrea Del Bene.
>>> Apache Wicket committer.
>> 
> 


Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by Andrea Del Bene <an...@gmail.com>.
Hi,

if you want to create a script to automate the release process you might 
find helpful the release script we use in Wicket. It performs different 
tasks but you can go straight to line 525 
(https://github.com/apache/wicket/blob/master/release.sh#L525) where you 
can find some script code to generate sha signature, commit archives to 
svn etc...


On 30/07/2018 12:05, jun liu wrote:
> Hi, Andrea
>
> We mainly use ’release-plugin’ to prepare for a release: upgrade pom version, package release candidate and deploy to maven central repo. Some processes are done manually, for example, 'generate sha512' and 'svn commit’.
> You have mentioned a good point, I think we can use a .sh script to make the whole process done automatically.
>
> Best regards,
> Jun
>
>> On 30 Jul 2018, at 15:14, Andrea Del Bene <an...@gmail.com> wrote:
>>
>> Hi Jun,
>>
>> just curious, is there a particular script or tool you use to build the
>> releases?
>>
>> Thank you.
>>
>> On Mon, Jul 30, 2018 at 4:11 AM, Yong Zhu <di...@gmail.com> wrote:
>>
>>> The source dir unzipped from the source zip is named
>>> 'incubator-dubbo-dubbo-2.6.3'. Here `dubbo` is duplicated.
>>>
>>> Is this intentional?
>>>
>>> On Mon, Jul 30, 2018 at 10:06 AM Jun Liu <li...@apache.org> wrote:
>>>
>>>>> I think I found an issue that may need to rebuild the release
>>> candidate.
>>>>> The source release contains a binary:
>>>>>
>>>>> ./.mvn/wrapper/maven-wrapper.jar
>>>> Yes, you are right, I have just checked and found the binary in the exact
>>>> position.
>>>> We can start the rebuild today.
>>>>
>>>> I failed to notice that the rat and style plugin are closed by default
>>>> when building the release candidate locally, I will open them in the next
>>>> RC, they can help to check this kind of problems.
>>>>
>>>> Best regards,
>>>> Jun
>>>>
>>>>> On 29 Jul 2018, at 16:14, Huxing Zhang <hu...@apache.org> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> I think I found an issue that may need to rebuild the release
>>> candidate.
>>>>> The source release contains a binary:
>>>>>
>>>>> ./.mvn/wrapper/maven-wrapper.jar
>>>>>
>>>>> Actually I run `mvn verify -Drat.skip=false`, as a result it found the
>>>>> archive in target/rat.txt but did not fail.
>>>>>
>>>>> Notes: 3
>>>>> Binaries: 0
>>>>> Archives: 1
>>>>> Standards: 3
>>>>>
>>>>> Apache Licensed: 3
>>>>> Generated Documents: 0
>>>>>
>>>>> JavaDocs are generated, thus a license header is optional.
>>>>> Generated files do not require license headers.
>>>>>
>>>>> 0 Unknown Licenses
>>>>>
>>>>> Archives:
>>>>>
>>>>> + .mvn/wrapper/maven-wrapper.jar
>>>>>
>>>>> Previous discussion:
>>>>>
>>>> https://lists.apache.org/thread.html/491ecd01802c48df8d906548e1d1db
>>> 188c39a9546f958e834198d276@%3Cdev.dubbo.apache.org%3E
>>>>>
>>>>> Other details:
>>>>>
>>>>> * incubator in name
>>>>> * Disclaimer exists
>>>>> * sha512 chesum ok
>>>>> * signature ok
>>>>> * git tag matches
>>>>> * NOTICE and LICENSE exist in META-INF of jar files of binary release.
>>>>> * Unit test passed on Java 8 + OSX
>>>>> * Tested elegant shutdown with Tomcat 8.5.30
>>>>>
>>>>> Minor issues:
>>>>> * There are some typo in CHANGES.md, I saw it fixed in 2.6.3 release
>>>>> branch, but not included in the release candidate.
>>>>>
>>>>> On Thu, Jul 26, 2018 at 5:48 PM, Jun Liu <li...@apache.org> wrote:
>>>>>> Hello Dubbo Community,
>>>>>>
>>>>>> This is a call for vote to release Apache Dubbo (Incubating) version
>>>> 2.6.3.
>>>>>> The release candidates (RC1):
>>>>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>>>>>>
>>>>>> Git tag for the release (RC1):
>>>>>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>>>>>>
>>>>>> Hash for the release tag:
>>>>>> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>>>>>>
>>>>>> Release Notes:
>>>>>> https://github.com/apache/incubator-dubbo/blob/2.6.3-
>>> release/CHANGES.md
>>>>>> The artifacts have been signed with Key : 28681CB1, which can be found
>>>> in the keys file:
>>>>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>>>>>>
>>>>>> The vote will be open for at least 72 hours or until necessary number
>>>> of votes are reached.
>>>>>> Please vote accordingly:
>>>>>>
>>>>>> [ ] +1 approve
>>>>>> [ ] +0 no opinion
>>>>>> [ ] -1 disapprove with the reason
>>>>>>
>>>>>> Thanks,
>>>>>> The Apache Dubbo (Incubating) Team
>>>>>>
>>>>> --
>>>>> Best Regards!
>>>>> Huxing
>>>>
>>
>>
>> -- 
>> Andrea Del Bene.
>> Apache Wicket committer.
>


Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by jun liu <ke...@gmail.com>.
Hi, Andrea

We mainly use ’release-plugin’ to prepare for a release: upgrade pom version, package release candidate and deploy to maven central repo. Some processes are done manually, for example, 'generate sha512' and 'svn commit’.
You have mentioned a good point, I think we can use a .sh script to make the whole process done automatically.

Best regards,
Jun

> On 30 Jul 2018, at 15:14, Andrea Del Bene <an...@gmail.com> wrote:
> 
> Hi Jun,
> 
> just curious, is there a particular script or tool you use to build the
> releases?
> 
> Thank you.
> 
> On Mon, Jul 30, 2018 at 4:11 AM, Yong Zhu <di...@gmail.com> wrote:
> 
>> The source dir unzipped from the source zip is named
>> 'incubator-dubbo-dubbo-2.6.3'. Here `dubbo` is duplicated.
>> 
>> Is this intentional?
>> 
>> On Mon, Jul 30, 2018 at 10:06 AM Jun Liu <li...@apache.org> wrote:
>> 
>>>> I think I found an issue that may need to rebuild the release
>> candidate.
>>>> 
>>>> The source release contains a binary:
>>>> 
>>>> ./.mvn/wrapper/maven-wrapper.jar
>>> 
>>> Yes, you are right, I have just checked and found the binary in the exact
>>> position.
>>> We can start the rebuild today.
>>> 
>>> I failed to notice that the rat and style plugin are closed by default
>>> when building the release candidate locally, I will open them in the next
>>> RC, they can help to check this kind of problems.
>>> 
>>> Best regards,
>>> Jun
>>> 
>>>> On 29 Jul 2018, at 16:14, Huxing Zhang <hu...@apache.org> wrote:
>>>> 
>>>> Hi,
>>>> 
>>>> I think I found an issue that may need to rebuild the release
>> candidate.
>>>> 
>>>> The source release contains a binary:
>>>> 
>>>> ./.mvn/wrapper/maven-wrapper.jar
>>>> 
>>>> Actually I run `mvn verify -Drat.skip=false`, as a result it found the
>>>> archive in target/rat.txt but did not fail.
>>>> 
>>>> Notes: 3
>>>> Binaries: 0
>>>> Archives: 1
>>>> Standards: 3
>>>> 
>>>> Apache Licensed: 3
>>>> Generated Documents: 0
>>>> 
>>>> JavaDocs are generated, thus a license header is optional.
>>>> Generated files do not require license headers.
>>>> 
>>>> 0 Unknown Licenses
>>>> 
>>>> Archives:
>>>> 
>>>> + .mvn/wrapper/maven-wrapper.jar
>>>> 
>>>> Previous discussion:
>>>> 
>>> https://lists.apache.org/thread.html/491ecd01802c48df8d906548e1d1db
>> 188c39a9546f958e834198d276@%3Cdev.dubbo.apache.org%3E
>>>> 
>>>> 
>>>> Other details:
>>>> 
>>>> * incubator in name
>>>> * Disclaimer exists
>>>> * sha512 chesum ok
>>>> * signature ok
>>>> * git tag matches
>>>> * NOTICE and LICENSE exist in META-INF of jar files of binary release.
>>>> * Unit test passed on Java 8 + OSX
>>>> * Tested elegant shutdown with Tomcat 8.5.30
>>>> 
>>>> Minor issues:
>>>> * There are some typo in CHANGES.md, I saw it fixed in 2.6.3 release
>>>> branch, but not included in the release candidate.
>>>> 
>>>> On Thu, Jul 26, 2018 at 5:48 PM, Jun Liu <li...@apache.org> wrote:
>>>>> Hello Dubbo Community,
>>>>> 
>>>>> This is a call for vote to release Apache Dubbo (Incubating) version
>>> 2.6.3.
>>>>> 
>>>>> The release candidates (RC1):
>>>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>>>>> 
>>>>> Git tag for the release (RC1):
>>>>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>>>>> 
>>>>> Hash for the release tag:
>>>>> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>>>>> 
>>>>> Release Notes:
>>>>> https://github.com/apache/incubator-dubbo/blob/2.6.3-
>> release/CHANGES.md
>>>>> 
>>>>> The artifacts have been signed with Key : 28681CB1, which can be found
>>> in the keys file:
>>>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>>>>> 
>>>>> The vote will be open for at least 72 hours or until necessary number
>>> of votes are reached.
>>>>> 
>>>>> Please vote accordingly:
>>>>> 
>>>>> [ ] +1 approve
>>>>> [ ] +0 no opinion
>>>>> [ ] -1 disapprove with the reason
>>>>> 
>>>>> Thanks,
>>>>> The Apache Dubbo (Incubating) Team
>>>>> 
>>>> 
>>>> --
>>>> Best Regards!
>>>> Huxing
>>> 
>>> 
>> 
> 
> 
> 
> -- 
> Andrea Del Bene.
> Apache Wicket committer.


Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by Andrea Del Bene <an...@gmail.com>.
Hi Jun,

just curious, is there a particular script or tool you use to build the
releases?

Thank you.

On Mon, Jul 30, 2018 at 4:11 AM, Yong Zhu <di...@gmail.com> wrote:

> The source dir unzipped from the source zip is named
> 'incubator-dubbo-dubbo-2.6.3'. Here `dubbo` is duplicated.
>
> Is this intentional?
>
> On Mon, Jul 30, 2018 at 10:06 AM Jun Liu <li...@apache.org> wrote:
>
> > > I think I found an issue that may need to rebuild the release
> candidate.
> > >
> > > The source release contains a binary:
> > >
> > > ./.mvn/wrapper/maven-wrapper.jar
> >
> > Yes, you are right, I have just checked and found the binary in the exact
> > position.
> > We can start the rebuild today.
> >
> > I failed to notice that the rat and style plugin are closed by default
> > when building the release candidate locally, I will open them in the next
> > RC, they can help to check this kind of problems.
> >
> > Best regards,
> > Jun
> >
> > > On 29 Jul 2018, at 16:14, Huxing Zhang <hu...@apache.org> wrote:
> > >
> > > Hi,
> > >
> > > I think I found an issue that may need to rebuild the release
> candidate.
> > >
> > > The source release contains a binary:
> > >
> > > ./.mvn/wrapper/maven-wrapper.jar
> > >
> > > Actually I run `mvn verify -Drat.skip=false`, as a result it found the
> > > archive in target/rat.txt but did not fail.
> > >
> > > Notes: 3
> > > Binaries: 0
> > > Archives: 1
> > > Standards: 3
> > >
> > > Apache Licensed: 3
> > > Generated Documents: 0
> > >
> > > JavaDocs are generated, thus a license header is optional.
> > > Generated files do not require license headers.
> > >
> > > 0 Unknown Licenses
> > >
> > > Archives:
> > >
> > > + .mvn/wrapper/maven-wrapper.jar
> > >
> > > Previous discussion:
> > >
> > https://lists.apache.org/thread.html/491ecd01802c48df8d906548e1d1db
> 188c39a9546f958e834198d276@%3Cdev.dubbo.apache.org%3E
> > >
> > >
> > > Other details:
> > >
> > > * incubator in name
> > > * Disclaimer exists
> > > * sha512 chesum ok
> > > * signature ok
> > > * git tag matches
> > > * NOTICE and LICENSE exist in META-INF of jar files of binary release.
> > > * Unit test passed on Java 8 + OSX
> > > * Tested elegant shutdown with Tomcat 8.5.30
> > >
> > > Minor issues:
> > > * There are some typo in CHANGES.md, I saw it fixed in 2.6.3 release
> > > branch, but not included in the release candidate.
> > >
> > > On Thu, Jul 26, 2018 at 5:48 PM, Jun Liu <li...@apache.org> wrote:
> > >> Hello Dubbo Community,
> > >>
> > >> This is a call for vote to release Apache Dubbo (Incubating) version
> > 2.6.3.
> > >>
> > >> The release candidates (RC1):
> > >> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
> > >>
> > >> Git tag for the release (RC1):
> > >> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
> > >>
> > >> Hash for the release tag:
> > >> a8be0eaaddab198ed03b0150d4db03e2b22f023f
> > >>
> > >> Release Notes:
> > >> https://github.com/apache/incubator-dubbo/blob/2.6.3-
> release/CHANGES.md
> > >>
> > >> The artifacts have been signed with Key : 28681CB1, which can be found
> > in the keys file:
> > >> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
> > >>
> > >> The vote will be open for at least 72 hours or until necessary number
> > of votes are reached.
> > >>
> > >> Please vote accordingly:
> > >>
> > >> [ ] +1 approve
> > >> [ ] +0 no opinion
> > >> [ ] -1 disapprove with the reason
> > >>
> > >> Thanks,
> > >> The Apache Dubbo (Incubating) Team
> > >>
> > >
> > > --
> > > Best Regards!
> > > Huxing
> >
> >
>



-- 
Andrea Del Bene.
Apache Wicket committer.

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by Yong Zhu <di...@gmail.com>.
The source dir unzipped from the source zip is named
'incubator-dubbo-dubbo-2.6.3'. Here `dubbo` is duplicated.

Is this intentional?

On Mon, Jul 30, 2018 at 10:06 AM Jun Liu <li...@apache.org> wrote:

> > I think I found an issue that may need to rebuild the release candidate.
> >
> > The source release contains a binary:
> >
> > ./.mvn/wrapper/maven-wrapper.jar
>
> Yes, you are right, I have just checked and found the binary in the exact
> position.
> We can start the rebuild today.
>
> I failed to notice that the rat and style plugin are closed by default
> when building the release candidate locally, I will open them in the next
> RC, they can help to check this kind of problems.
>
> Best regards,
> Jun
>
> > On 29 Jul 2018, at 16:14, Huxing Zhang <hu...@apache.org> wrote:
> >
> > Hi,
> >
> > I think I found an issue that may need to rebuild the release candidate.
> >
> > The source release contains a binary:
> >
> > ./.mvn/wrapper/maven-wrapper.jar
> >
> > Actually I run `mvn verify -Drat.skip=false`, as a result it found the
> > archive in target/rat.txt but did not fail.
> >
> > Notes: 3
> > Binaries: 0
> > Archives: 1
> > Standards: 3
> >
> > Apache Licensed: 3
> > Generated Documents: 0
> >
> > JavaDocs are generated, thus a license header is optional.
> > Generated files do not require license headers.
> >
> > 0 Unknown Licenses
> >
> > Archives:
> >
> > + .mvn/wrapper/maven-wrapper.jar
> >
> > Previous discussion:
> >
> https://lists.apache.org/thread.html/491ecd01802c48df8d906548e1d1db188c39a9546f958e834198d276@%3Cdev.dubbo.apache.org%3E
> >
> >
> > Other details:
> >
> > * incubator in name
> > * Disclaimer exists
> > * sha512 chesum ok
> > * signature ok
> > * git tag matches
> > * NOTICE and LICENSE exist in META-INF of jar files of binary release.
> > * Unit test passed on Java 8 + OSX
> > * Tested elegant shutdown with Tomcat 8.5.30
> >
> > Minor issues:
> > * There are some typo in CHANGES.md, I saw it fixed in 2.6.3 release
> > branch, but not included in the release candidate.
> >
> > On Thu, Jul 26, 2018 at 5:48 PM, Jun Liu <li...@apache.org> wrote:
> >> Hello Dubbo Community,
> >>
> >> This is a call for vote to release Apache Dubbo (Incubating) version
> 2.6.3.
> >>
> >> The release candidates (RC1):
> >> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
> >>
> >> Git tag for the release (RC1):
> >> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
> >>
> >> Hash for the release tag:
> >> a8be0eaaddab198ed03b0150d4db03e2b22f023f
> >>
> >> Release Notes:
> >> https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md
> >>
> >> The artifacts have been signed with Key : 28681CB1, which can be found
> in the keys file:
> >> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
> >>
> >> The vote will be open for at least 72 hours or until necessary number
> of votes are reached.
> >>
> >> Please vote accordingly:
> >>
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >>
> >> Thanks,
> >> The Apache Dubbo (Incubating) Team
> >>
> >
> > --
> > Best Regards!
> > Huxing
>
>

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by Jun Liu <li...@apache.org>.
> I think I found an issue that may need to rebuild the release candidate.
> 
> The source release contains a binary:
> 
> ./.mvn/wrapper/maven-wrapper.jar

Yes, you are right, I have just checked and found the binary in the exact position.
We can start the rebuild today. 

I failed to notice that the rat and style plugin are closed by default when building the release candidate locally, I will open them in the next RC, they can help to check this kind of problems.

Best regards,
Jun

> On 29 Jul 2018, at 16:14, Huxing Zhang <hu...@apache.org> wrote:
> 
> Hi,
> 
> I think I found an issue that may need to rebuild the release candidate.
> 
> The source release contains a binary:
> 
> ./.mvn/wrapper/maven-wrapper.jar
> 
> Actually I run `mvn verify -Drat.skip=false`, as a result it found the
> archive in target/rat.txt but did not fail.
> 
> Notes: 3
> Binaries: 0
> Archives: 1
> Standards: 3
> 
> Apache Licensed: 3
> Generated Documents: 0
> 
> JavaDocs are generated, thus a license header is optional.
> Generated files do not require license headers.
> 
> 0 Unknown Licenses
> 
> Archives:
> 
> + .mvn/wrapper/maven-wrapper.jar
> 
> Previous discussion:
> https://lists.apache.org/thread.html/491ecd01802c48df8d906548e1d1db188c39a9546f958e834198d276@%3Cdev.dubbo.apache.org%3E
> 
> 
> Other details:
> 
> * incubator in name
> * Disclaimer exists
> * sha512 chesum ok
> * signature ok
> * git tag matches
> * NOTICE and LICENSE exist in META-INF of jar files of binary release.
> * Unit test passed on Java 8 + OSX
> * Tested elegant shutdown with Tomcat 8.5.30
> 
> Minor issues:
> * There are some typo in CHANGES.md, I saw it fixed in 2.6.3 release
> branch, but not included in the release candidate.
> 
> On Thu, Jul 26, 2018 at 5:48 PM, Jun Liu <li...@apache.org> wrote:
>> Hello Dubbo Community,
>> 
>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
>> 
>> The release candidates (RC1):
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>> 
>> Git tag for the release (RC1):
>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>> 
>> Hash for the release tag:
>> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>> 
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md
>> 
>> The artifacts have been signed with Key : 28681CB1, which can be found in the keys file:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>> 
>> The vote will be open for at least 72 hours or until necessary number of votes are reached.
>> 
>> Please vote accordingly:
>> 
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>> 
>> Thanks,
>> The Apache Dubbo (Incubating) Team
>> 
> 
> -- 
> Best Regards!
> Huxing


Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by Huxing Zhang <hu...@apache.org>.
Hi,

I think I found an issue that may need to rebuild the release candidate.

The source release contains a binary:

./.mvn/wrapper/maven-wrapper.jar

Actually I run `mvn verify -Drat.skip=false`, as a result it found the
archive in target/rat.txt but did not fail.

Notes: 3
Binaries: 0
Archives: 1
Standards: 3

Apache Licensed: 3
Generated Documents: 0

JavaDocs are generated, thus a license header is optional.
Generated files do not require license headers.

0 Unknown Licenses

Archives:

 + .mvn/wrapper/maven-wrapper.jar

Previous discussion:
https://lists.apache.org/thread.html/491ecd01802c48df8d906548e1d1db188c39a9546f958e834198d276@%3Cdev.dubbo.apache.org%3E


Other details:

* incubator in name
* Disclaimer exists
* sha512 chesum ok
* signature ok
* git tag matches
* NOTICE and LICENSE exist in META-INF of jar files of binary release.
* Unit test passed on Java 8 + OSX
* Tested elegant shutdown with Tomcat 8.5.30

Minor issues:
* There are some typo in CHANGES.md, I saw it fixed in 2.6.3 release
branch, but not included in the release candidate.

On Thu, Jul 26, 2018 at 5:48 PM, Jun Liu <li...@apache.org> wrote:
> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
>
> The release candidates (RC1):
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>
> Git tag for the release (RC1):
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>
> Hash for the release tag:
> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>
> Release Notes:
> https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md
>
> The artifacts have been signed with Key : 28681CB1, which can be found in the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team
>

-- 
Best Regards!
Huxing

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by jun liu <ke...@gmail.com>.
> I've investigated and  found
> that the pom.xml has version 2.6.4-SNAPSHOT instead of 2.6.3

Sorry, It turns out that I have committed the wrong package. That’s not supported to be the 2.6.3 RC1. I have updated the package in svn: https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3. 

Since the release candidates are not changed at all, I think we can continue with this vote if that’s allowed by an Apache release process.

Best regards,
Jun

> On 27 Jul 2018, at 17:43, Andrea Del Bene <an...@gmail.com> wrote:
> 
> I'm afraid I've found a problem with source archive
> (dubbo-incubating-2.6.3-source-release.zip). I'm not able to build the
> release from scratch (with 'mvn install'), I've investigated and  found
> that the pom.xml has version 2.6.4-SNAPSHOT instead of 2.6.3
> 
> On Fri, Jul 27, 2018 at 4:49 AM, jun liu <ke...@gmail.com> wrote:
> 
>>> +1
>>> So many enhancements and  features, more ducuments would be better.
>> 
>> Sure, we will try to complete the docs.
>> 
>> Best regards,
>> Jun
>> 
>>> On 27 Jul 2018, at 09:25, ? ?? <le...@live.cn> wrote:
>>> 
>>> +1
>>> So many enhancements and  features, more ducuments would be better.
>>> 
>>> ________________________________
>>> leyou240@live.cn
>>> 
>>> From: Jun Liu<ma...@apache.org>
>>> Date: 2018-07-26 17:48
>>> To: dev@dubbo.apache.org<ma...@dubbo.apache.org>
>>> Subject: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]
>>> Hello Dubbo Community,
>>> 
>>> This is a call for vote to release Apache Dubbo (Incubating) version
>> 2.6.3.
>>> 
>>> The release candidates (RC1):
>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>>> 
>>> Git tag for the release (RC1):
>>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>>> 
>>> Hash for the release tag:
>>> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>>> 
>>> Release Notes:
>>> https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md
>>> 
>>> The artifacts have been signed with Key : 28681CB1, which can be found
>> in the keys file:
>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>>> 
>>> The vote will be open for at least 72 hours or until necessary number of
>> votes are reached.
>>> 
>>> Please vote accordingly:
>>> 
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>> 
>>> Thanks,
>>> The Apache Dubbo (Incubating) Team
>>> 
>> 
>> 
> 
> 
> -- 
> Andrea Del Bene.
> Apache Wicket committer.


Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by Andrea Del Bene <an...@gmail.com>.
I'm afraid I've found a problem with source archive
(dubbo-incubating-2.6.3-source-release.zip). I'm not able to build the
release from scratch (with 'mvn install'), I've investigated and  found
that the pom.xml has version 2.6.4-SNAPSHOT instead of 2.6.3

On Fri, Jul 27, 2018 at 4:49 AM, jun liu <ke...@gmail.com> wrote:

> > +1
> > So many enhancements and  features, more ducuments would be better.
>
> Sure, we will try to complete the docs.
>
> Best regards,
> Jun
>
> > On 27 Jul 2018, at 09:25, ? ?? <le...@live.cn> wrote:
> >
> > +1
> > So many enhancements and  features, more ducuments would be better.
> >
> > ________________________________
> > leyou240@live.cn
> >
> > From: Jun Liu<ma...@apache.org>
> > Date: 2018-07-26 17:48
> > To: dev@dubbo.apache.org<ma...@dubbo.apache.org>
> > Subject: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]
> > Hello Dubbo Community,
> >
> > This is a call for vote to release Apache Dubbo (Incubating) version
> 2.6.3.
> >
> > The release candidates (RC1):
> > https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
> >
> > Git tag for the release (RC1):
> > https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
> >
> > Hash for the release tag:
> > a8be0eaaddab198ed03b0150d4db03e2b22f023f
> >
> > Release Notes:
> > https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md
> >
> > The artifacts have been signed with Key : 28681CB1, which can be found
> in the keys file:
> > https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo (Incubating) Team
> >
>
>


-- 
Andrea Del Bene.
Apache Wicket committer.

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by jun liu <ke...@gmail.com>.
> +1
> So many enhancements and  features, more ducuments would be better.

Sure, we will try to complete the docs.

Best regards,
Jun

> On 27 Jul 2018, at 09:25, ? ?? <le...@live.cn> wrote:
> 
> +1
> So many enhancements and  features, more ducuments would be better.
> 
> ________________________________
> leyou240@live.cn
> 
> From: Jun Liu<ma...@apache.org>
> Date: 2018-07-26 17:48
> To: dev@dubbo.apache.org<ma...@dubbo.apache.org>
> Subject: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]
> Hello Dubbo Community,
> 
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
> 
> The release candidates (RC1):
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
> 
> Git tag for the release (RC1):
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
> 
> Hash for the release tag:
> a8be0eaaddab198ed03b0150d4db03e2b22f023f
> 
> Release Notes:
> https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md
> 
> The artifacts have been signed with Key : 28681CB1, which can be found in the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
> 
> The vote will be open for at least 72 hours or until necessary number of votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Dubbo (Incubating) Team
> 


Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]

Posted by ? ?? <le...@live.cn>.
+1
So many enhancements and  features, more ducuments would be better.

________________________________
leyou240@live.cn

From: Jun Liu<ma...@apache.org>
Date: 2018-07-26 17:48
To: dev@dubbo.apache.org<ma...@dubbo.apache.org>
Subject: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC1]
Hello Dubbo Community,

This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.

The release candidates (RC1):
https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3

Git tag for the release (RC1):
https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3

Hash for the release tag:
a8be0eaaddab198ed03b0150d4db03e2b22f023f

Release Notes:
https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md

The artifacts have been signed with Key : 28681CB1, which can be found in the keys file:
https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS

The vote will be open for at least 72 hours or until necessary number of votes are reached.

Please vote accordingly:

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason

Thanks,
The Apache Dubbo (Incubating) Team