[GitHub] [tvm] zxybazh commented on a diff in pull request #13561: [MetaSchedule] Restore `num_threads` parameter in tuning API

[GitBox <gi...@apache.org>]

zxybazh commented on code in PR #13561:
URL: https://github.com/apache/tvm/pull/13561#discussion_r1041342637


##########
tests/python/contrib/test_hexagon/metaschedule_e2e/test_resnet50_int8.py:
##########
@@ -125,8 +142,8 @@ def tune_vrmpy_auto_tensorize(mod, params, hexagon_launcher):
             # num_trials_per_iter=32,
             # max_trials_per_task=128,
             # strategy="evolutionary",
-            builder=get_hexagon_local_builder(),
-            runner=get_hexagon_rpc_runner(hexagon_launcher, number=20),
+            builder=get_hexagon_local_builder(max_workers=num_threads),

Review Comment:
   I also find the name of `num_threads` maybe a bit confusing for builder / runners because they are managed with PopenPool Workers, basically new processes. We can consider some better naming, maybe `parallelism`?



##########
python/tvm/meta_schedule/relay_integration.py:
##########
@@ -249,6 +249,7 @@ def tune_relay(
     strategy: SearchStrategy.SearchStrategyType = "evolutionary",
     seed: Optional[int] = None,
     module_equality: str = "structural",
+    num_threads: Union[Literal["physical", "logical"], int] = "physical",

Review Comment:
   Do we have some logic to process `physical` `logical` as input here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org