You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Eduardo Kienetz <ed...@kienetz.com> on 2009/10/08 21:37:01 UTC

assertion failed (opt || cstr)

Guys, I got this message today and was told to e-mail it to the dev team:

In file
'D:\Development\SVN\Releases\TortoiseSVN-1.6.5\ext\subversion\subversion\libsvn_ra_svn\marshal.c'

line 486: assertion failed (opt || cstr)

I don't think I'll be able to reproduce though (I'm not a "pro" user, just
know I was trying to reintegrate/merge a branch).

I'm not subscribed to the list, so if you need to contact me please use my
e-mail address.

Thank you in advance for the great software.

Eduardo Bacchi Kienetz

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405322

Re: assertion failed (opt || cstr)

Posted by Stefan Sperling <st...@elego.de>.
On Fri, Oct 09, 2009 at 09:29:51PM +0200, Stefan Küng wrote:
> On 09.10.2009 19:51, Stefan Sperling wrote:
> > Hi Stefan,
> >
> > could TortroiseSVN be changed to suggest searching the mailing list
> > archives for the error message (ideally pointing people to the archive URL)
> > before posting to the mailing list?
> >
> > We keep getting this problem report on a regular basis.
> 
> Done in r17390 and merged back to our stable 1.6.x branch in r17391. So 
> the error message will tell users to first search the archives as of the 
> next release (1.6.6).

Nice, thank you very much!

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405659

Re: assertion failed (opt || cstr)

Posted by Stefan Küng <to...@gmail.com>.
On 09.10.2009 19:51, Stefan Sperling wrote:
> Hi Stefan,
>
> could TortroiseSVN be changed to suggest searching the mailing list
> archives for the error message (ideally pointing people to the archive URL)
> before posting to the mailing list?
>
> We keep getting this problem report on a regular basis.

Done in r17390 and merged back to our stable 1.6.x branch in r17391. So 
the error message will tell users to first search the archives as of the 
next release (1.6.6).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405650

Re: assertion failed (opt || cstr)

Posted by Stefan Sperling <st...@elego.de>.
Hi Stefan,

could TortroiseSVN be changed to suggest searching the mailing list
archives for the error message (ideally pointing people to the archive URL)
before posting to the mailing list?

We keep getting this problem report on a regular basis.

Thanks,
Stefan

On Thu, Oct 08, 2009 at 03:37:01PM -0600, Eduardo Kienetz wrote:
> Guys, I got this message today and was told to e-mail it to the dev team:
> 
> In file
> 'D:\Development\SVN\Releases\TortoiseSVN-1.6.5\ext\subversion\subversion\libsvn_ra_svn\marshal.c'
> 
> line 486: assertion failed (opt || cstr)
> 
> I don't think I'll be able to reproduce though (I'm not a "pro" user, just
> know I was trying to reintegrate/merge a branch).
> 
> I'm not subscribed to the list, so if you need to contact me please use my
> e-mail address.
> 
> Thank you in advance for the great software.
> 
> Eduardo Bacchi Kienetz
> 
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405322

-- 
printf("Eh???/n");

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405614

Re: assertion failed (opt || cstr)

Posted by Mark Phippard <ma...@gmail.com>.
On Fri, Oct 9, 2009 at 2:19 PM, Stefan Sperling <st...@elego.de> wrote:

> Well, Bert has fixed the only known way of reproducing this bug.
> See http://subversion.tigris.org/issues/show_bug.cgi?id=3485
> The bug was deep inside the ra_svn code. I'd say it's quite possible
> that all these reports are caused by this same bug.
>
> We cannot be sure, of course, but all we can do now is to tell people
> to upgrade to 1.6.6. And should that turn out not to help all users,
> we will hear about it.
>
> I mean, what else would you do?

I know, and I hope we have completely fixed it.  I just seem to recall
this message and fixes for it have happened in the past.

I would possibly tell people we think we have fixed it for 1.6.6 and
point them to the issue.  If the reproduction recipe in the issue does
not sound the same, then maybe they can provide their recipe.  Or they
can wait and see.

-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405651

Re: assertion failed (opt || cstr)

Posted by Stefan Sperling <st...@elego.de>.
On Fri, Oct 09, 2009 at 01:54:36PM -0400, Mark Phippard wrote:
> On Fri, Oct 9, 2009 at 9:02 AM, Stefan Sperling <st...@elego.de> wrote:
> > On Thu, Oct 08, 2009 at 03:37:01PM -0600, Eduardo Kienetz wrote:
> >> Guys, I got this message today and was told to e-mail it to the dev team:
> >>
> >> In file
> >> 'D:\Development\SVN\Releases\TortoiseSVN-1.6.5\ext\subversion\subversion\libsvn_ra_svn\marshal.c'
> >>
> >> line 486: assertion failed (opt || cstr)
> >>
> >> I don't think I'll be able to reproduce though (I'm not a "pro" user, just
> >> know I was trying to reintegrate/merge a branch).
> >>
> >> I'm not subscribed to the list, so if you need to contact me please use my
> >> e-mail address.
> >
> > This is known and has been fixed.
> > The fix will be released in 1.6.6 next week.
> 
> FWIW, I would not be so certain that the problem is "fixed".  People
> have been getting that error message for years, which tells me it is
> simply the error message you get when an entire class of problems in
> the svnserve protocol happens.
> 
> It will be great if you fixed it, but it is possible you simply fixed
> one scenario you knew about and looked at.

Well, Bert has fixed the only known way of reproducing this bug.
See http://subversion.tigris.org/issues/show_bug.cgi?id=3485
The bug was deep inside the ra_svn code. I'd say it's quite possible
that all these reports are caused by this same bug.

We cannot be sure, of course, but all we can do now is to tell people
to upgrade to 1.6.6. And should that turn out not to help all users,
we will hear about it.

I mean, what else would you do?
I guess we could phrase it as "Please try 1.6.6 and see if that helps"
if you prefer. Then again we could use this wording for *any* bug we fix.
Because the only way to know if a bug still exists is a good reproduction
recipe that triggers it. Otherwise, all we can do is assume it fixed and
hope that it will never surface again.

So let's just wait and see if these reports finally subside once enough
people have upgraded to 1.6.6.

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405627

Re: assertion failed (opt || cstr)

Posted by Mark Phippard <ma...@gmail.com>.
On Fri, Oct 9, 2009 at 9:02 AM, Stefan Sperling <st...@elego.de> wrote:
> On Thu, Oct 08, 2009 at 03:37:01PM -0600, Eduardo Kienetz wrote:
>> Guys, I got this message today and was told to e-mail it to the dev team:
>>
>> In file
>> 'D:\Development\SVN\Releases\TortoiseSVN-1.6.5\ext\subversion\subversion\libsvn_ra_svn\marshal.c'
>>
>> line 486: assertion failed (opt || cstr)
>>
>> I don't think I'll be able to reproduce though (I'm not a "pro" user, just
>> know I was trying to reintegrate/merge a branch).
>>
>> I'm not subscribed to the list, so if you need to contact me please use my
>> e-mail address.
>
> This is known and has been fixed.
> The fix will be released in 1.6.6 next week.

FWIW, I would not be so certain that the problem is "fixed".  People
have been getting that error message for years, which tells me it is
simply the error message you get when an entire class of problems in
the svnserve protocol happens.

It will be great if you fixed it, but it is possible you simply fixed
one scenario you knew about and looked at.

-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405618

Re: assertion failed (opt || cstr)

Posted by Stefan Sperling <st...@elego.de>.
On Thu, Oct 08, 2009 at 03:37:01PM -0600, Eduardo Kienetz wrote:
> Guys, I got this message today and was told to e-mail it to the dev team:
> 
> In file
> 'D:\Development\SVN\Releases\TortoiseSVN-1.6.5\ext\subversion\subversion\libsvn_ra_svn\marshal.c'
> 
> line 486: assertion failed (opt || cstr)
> 
> I don't think I'll be able to reproduce though (I'm not a "pro" user, just
> know I was trying to reintegrate/merge a branch).
> 
> I'm not subscribed to the list, so if you need to contact me please use my
> e-mail address.

This is known and has been fixed.
The fix will be released in 1.6.6 next week.

Thank you,
Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405609