You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/27 06:40:08 UTC
[GitHub] [superset] gforien opened a new pull request, #20883: Feat/helm/add separate replicacount
gforien opened a new pull request, #20883:
URL: https://github.com/apache/superset/pull/20883
### SUMMARY
We want to configure a different replicaCount for `supersetNode` and `supersetWorker` deployments, as they do not undergo the same load.
The `replicaCount` should be configurable on a per component level instead of globally for the whole chart.
### TESTING INSTRUCTIONS
Templating can be verified manually with `helm template`
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #19250
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] gforien commented on a diff in pull request #20883: feat(helm): support different replicaCount
Posted by GitBox <gi...@apache.org>.
gforien commented on code in PR #20883:
URL: https://github.com/apache/superset/pull/20883#discussion_r931907199
##########
helm/superset/templates/deployment-worker.yaml:
##########
@@ -28,7 +28,11 @@ metadata:
{{ toYaml .Values.supersetWorker.deploymentAnnotations | nindent 4 }}
{{- end }}
spec:
+ {{- if .Values.supersetWorker.replicaCount }}
+ replicas: {{ .Values.supersetWorker.replicaCount }}
+ {{- else }}
Review Comment:
Ok so I did
- remove `replicaCount` in the values, in the schema, and in the array of required values
- add `supersetNode.replicaCount` and `supersetWorker.replicaCount` in the values, in the schema, and in the array of required values
- edit the "Running on Kubernetes" doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #20883: feat(helm): support different replicaCount
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on code in PR #20883:
URL: https://github.com/apache/superset/pull/20883#discussion_r931285715
##########
helm/superset/templates/deployment-worker.yaml:
##########
@@ -28,7 +28,11 @@ metadata:
{{ toYaml .Values.supersetWorker.deploymentAnnotations | nindent 4 }}
{{- end }}
spec:
+ {{- if .Values.supersetWorker.replicaCount }}
+ replicas: {{ .Values.supersetWorker.replicaCount }}
+ {{- else }}
Review Comment:
Just make a new value under `supersetWorker` and use it here (default of the current `replicaCount`)
##########
helm/superset/templates/deployment.yaml:
##########
@@ -28,7 +28,11 @@ metadata:
{{ toYaml .Values.supersetNode.deploymentAnnotations | nindent 4 }}
{{- end }}
spec:
+ {{- if .Values.supersetNode.replicaCount }}
+ replicas: {{ .Values.supersetNode.replicaCount }}
+ {{- else }}
Review Comment:
Same comment as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #20883: feat(helm): support different replicaCount
Posted by GitBox <gi...@apache.org>.
craig-rueda merged PR #20883:
URL: https://github.com/apache/superset/pull/20883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] gforien commented on a diff in pull request #20883: feat(helm): support different replicaCount
Posted by GitBox <gi...@apache.org>.
gforien commented on code in PR #20883:
URL: https://github.com/apache/superset/pull/20883#discussion_r931907199
##########
helm/superset/templates/deployment-worker.yaml:
##########
@@ -28,7 +28,11 @@ metadata:
{{ toYaml .Values.supersetWorker.deploymentAnnotations | nindent 4 }}
{{- end }}
spec:
+ {{- if .Values.supersetWorker.replicaCount }}
+ replicas: {{ .Values.supersetWorker.replicaCount }}
+ {{- else }}
Review Comment:
Ok so I did
- remove `replicaCount` in the values, in the schema, and in the array of required values
- add `supersetNode.replicaCount` and `supersetWorker.replicaCount` in the values, in the schema, and in the array of required values
- edit the "Running on Kubernetes" doc
- bump version to 0.7.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org