[GitHub] [kafka] divijvaidya commented on pull request #12224: MINOR: Make LocalLogManager implementation consistent with the RaftClient interface contract

[GitBox <gi...@apache.org>]

divijvaidya commented on PR #12224:
URL: https://github.com/apache/kafka/pull/12224#issuecomment-1149619718

   > For my understanding, what is the motivation for this change?
   
   Apologies for late response @jsancio (I was on leave) and thank you for your review. 
   
   It's interesting that you ask this question because there indeed is a motivation. I was trying to fix the flaky test described in https://issues.apache.org/jira/browse/KAFKA-13943. As you will observe from the stack trace, due to the bug fixed here in this PR, a snapshot was being created with LONG_MAX offset and thus leading to further cascading failures. The test is flaky because it only happens when an append request started off from a leader but when the request was waiting for synchronized lock in the tryAppend() method, the leader changed. Sometimes, the leader doesn't change while it is waiting and sometimes it does. With this fix, I hope to fix that bug.
   
   Does this answer your question? Please feel free to add your thoughts to the JIRA directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org