You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by yo...@apache.org on 2013/05/31 20:37:24 UTC
svn commit: r1488349 - in /lucene/dev/trunk/solr: ./
core/src/java/org/apache/solr/core/ core/src/java/org/apache/solr/update/
core/src/test/org/apache/solr/search/
Author: yonik
Date: Fri May 31 18:37:24 2013
New Revision: 1488349
URL: http://svn.apache.org/r1488349
Log:
SOLR-4858: call ulog.init on core reopen
Modified:
lucene/dev/trunk/solr/CHANGES.txt
lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java
lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java
lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateHandler.java
lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateLog.java
lucene/dev/trunk/solr/core/src/test/org/apache/solr/search/TestRecovery.java
Modified: lucene/dev/trunk/solr/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/CHANGES.txt?rev=1488349&r1=1488348&r2=1488349&view=diff
==============================================================================
--- lucene/dev/trunk/solr/CHANGES.txt (original)
+++ lucene/dev/trunk/solr/CHANGES.txt Fri May 31 18:37:24 2013
@@ -220,6 +220,10 @@ Bug Fixes
EmptyEntityResolver to prevent loading of external entities like
UpdateRequestHandler does. (Hossman, Uwe Schindler)
+* SOLR-4858: SolrCore reloading was broken when the UpdateLog
+ was enabled. (Hossman, Anshum Gupta, Alexey Serba, Mark Miller, yonik)
+
+
Other Changes
----------------------
Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java?rev=1488349&r1=1488348&r2=1488349&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrCore.java Fri May 31 18:37:24 2013
@@ -1352,6 +1352,10 @@ public final class SolrCore implements S
* This method acquires openSearcherLock - do not call with searckLock held!
*/
public RefCounted<SolrIndexSearcher> openNewSearcher(boolean updateHandlerReopens, boolean realtime) {
+ if (isClosed()) { // catch some errors quicker
+ throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "openNewSearcher called on closed core");
+ }
+
SolrIndexSearcher tmp;
RefCounted<SolrIndexSearcher> newestSearcher = null;
boolean nrt = solrConfig.reopenReaders && updateHandlerReopens;
Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java?rev=1488349&r1=1488348&r2=1488349&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java Fri May 31 18:37:24 2013
@@ -108,6 +108,8 @@ public class DirectUpdateHandler2 extend
softCommitTracker = new CommitTracker("Soft", core, softCommitDocsUpperBound, softCommitTimeUpperBound, true, true);
commitWithinSoftCommit = updateHandlerInfo.commitWithinSoftCommit;
+
+
}
public DirectUpdateHandler2(SolrCore core, UpdateHandler updateHandler) {
@@ -125,6 +127,13 @@ public class DirectUpdateHandler2 extend
softCommitTracker = new CommitTracker("Soft", core, softCommitDocsUpperBound, softCommitTimeUpperBound, updateHandlerInfo.openSearcher, true);
commitWithinSoftCommit = updateHandlerInfo.commitWithinSoftCommit;
+
+ UpdateLog existingLog = updateHandler.getUpdateLog();
+ if (this.ulog != null && this.ulog == existingLog) {
+ // If we are reusing the existing update log, inform the log that it's update handler has changed.
+ // We do this as late as possible.
+ this.ulog.init(this, core);
+ }
}
private void deleteAll() throws IOException {
Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateHandler.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateHandler.java?rev=1488349&r1=1488348&r2=1488349&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateHandler.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateHandler.java Fri May 31 18:37:24 2013
@@ -52,7 +52,7 @@ public abstract class UpdateHandler impl
protected Vector<SolrEventListener> softCommitCallbacks = new Vector<SolrEventListener>();
protected Vector<SolrEventListener> optimizeCallbacks = new Vector<SolrEventListener>();
- protected volatile UpdateLog ulog;
+ protected UpdateLog ulog;
private void parseEventListeners() {
final Class<SolrEventListener> clazz = SolrEventListener.class;
@@ -72,13 +72,15 @@ public abstract class UpdateHandler impl
}
- private void initLog(PluginInfo ulogPluginInfo) {
- if (ulogPluginInfo != null && ulogPluginInfo.isEnabled()) {
+ private void initLog(PluginInfo ulogPluginInfo, UpdateLog existingUpdateLog) {
+ ulog = existingUpdateLog;
+ if (ulog == null && ulogPluginInfo != null && ulogPluginInfo.isEnabled()) {
ulog = new UpdateLog();
ulog.init(ulogPluginInfo);
// ulog = core.createInitInstance(ulogPluginInfo, UpdateLog.class, "update log", "solr.NullUpdateLog");
ulog.init(this, core);
}
+ // ulog.init() when reusing an existing log is deferred (currently at the end of the DUH2 constructor
}
// not thread safe - for startup
@@ -130,11 +132,7 @@ public abstract class UpdateHandler impl
if (!core.isReloaded() && !core.getDirectoryFactory().isPersistent()) {
clearLog(ulogPluginInfo);
}
- if (updateLog == null) {
- initLog(ulogPluginInfo);
- } else {
- this.ulog = updateLog;
- }
+ initLog(ulogPluginInfo, updateLog);
}
/**
Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateLog.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateLog.java?rev=1488349&r1=1488348&r2=1488349&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateLog.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/update/UpdateLog.java Fri May 31 18:37:24 2013
@@ -189,6 +189,10 @@ public class UpdateLog implements Plugin
defaultSyncLevel = SyncLevel.getSyncLevel((String)info.initArgs.get("syncLevel"));
}
+ /* Note, when this is called, uhandler is not completely constructed.
+ * This must be called when a new log is created, or
+ * for an existing log whenever the core or update handler changes.
+ */
public void init(UpdateHandler uhandler, SolrCore core) {
// ulogDir from CoreDescriptor overrides
String ulogDir = core.getCoreDescriptor().getUlogDir();
Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/search/TestRecovery.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/search/TestRecovery.java?rev=1488349&r1=1488348&r2=1488349&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/search/TestRecovery.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/search/TestRecovery.java Fri May 31 18:37:24 2013
@@ -17,6 +17,7 @@
package org.apache.solr.search;
+import org.apache.solr.common.SolrException;
import org.noggit.ObjectBuilder;
import org.apache.solr.SolrTestCaseJ4;
import org.apache.solr.request.SolrQueryRequest;
@@ -487,7 +488,40 @@ public class TestRecovery extends SolrTe
}
+
+ // we need to make sure that the log is informed of a core reload
@Test
+ public void testReload() throws Exception {
+ long version = addAndGetVersion(sdoc("id","reload1") , null);
+
+ h.reload();
+
+ version = addAndGetVersion(sdoc("id","reload1", "_version_", Long.toString(version)), null);
+
+ assertU(commit());
+
+ // if we try the optimistic concurrency again, the tlog lookup maps should be clear
+ // and we should go to the index to check the version. This indirectly tests that
+ // the update log was informed of the reload. See SOLR-4858
+
+ version = addAndGetVersion(sdoc("id","reload1", "_version_", Long.toString(version)), null);
+
+ // a deleteByQuery currently forces open a new realtime reader via the update log.
+ // This also tests that the update log was informed of the new udpate handler.
+
+ deleteByQueryAndGetVersion("foo_t:hownowbrowncow", null);
+
+ version = addAndGetVersion(sdoc("id","reload1", "_version_", Long.toString(version)), null);
+
+ // if the update log was not informed of the new update handler, then the old core will
+ // incorrectly be used for some of the operations above and opened searchers
+ // will never be closed. This used to cause the test framework to fail because of unclosed directory checks.
+ // SolrCore.openNewSearcher was modified to throw an error if the core is closed, resulting in
+ // a faster fail.
+ }
+
+
+ @Test
public void testBufferingFlags() throws Exception {
DirectUpdateHandler2.commitOnClose = false;