[GitHub] [iceberg] pvary commented on a change in pull request #2551: Filtering dictionary encoded FIX_LEN_BYTE_ARRAY

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2551:
URL: https://github.com/apache/iceberg/pull/2551#discussion_r633422087



##########
File path: parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java
##########
@@ -140,6 +152,7 @@ public void createInputFile() throws IOException {
     OutputFile outFile = Files.localOutput(parquetFile);
     try (FileAppender<Record> appender = Parquet.write(outFile)
         .schema(FILE_SCHEMA)
+        .withWriterVersion(WriterVersion.PARQUET_2_0) // V2 is needed to force dictionary encoding for FIXED type

Review comment:
       @rdblue: Does Iceberg specification defines which writer version we should use?
   
   @gszadovszky: What happens when a V2 writer is used and an old parquet client tries to read the file.
   
   Thanks,
   Peter




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org