You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Philippe Mouawad (JIRA)" <ji...@apache.org> on 2011/05/22 10:47:47 UTC
[jira] [Created] (OFBIZ-4290) UtilCache#getPropertyParam should
test property existence instead of rely on MissingResourceException
UtilCache#getPropertyParam should test property existence instead of rely on MissingResourceException
------------------------------------------------------------------------------------------------------
Key: OFBIZ-4290
URL: https://issues.apache.org/jira/browse/OFBIZ-4290
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Reporter: Philippe Mouawad
Priority: Minor
Attachments: patch-OFBIZ-4290.patch
Hello,
UtilCache#getPropertyParam should call res.containsKey instead of relying on catching MissingResourceException, which will reduce number of Exceptions created so CPU.
Regards
Philippe
http://www.ubik-ingenierie.com
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4290) UtilCache#getPropertyParam should test
property existence instead of rely on MissingResourceException
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-4290.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Jacques Le Roux
Thanks Philippe,
Based on http://stackoverflow.com/questions/299068/how-slow-are-java-exceptions I agree
Your patch is in trunk at r1126379
> UtilCache#getPropertyParam should test property existence instead of rely on MissingResourceException
> ------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4290
> URL: https://issues.apache.org/jira/browse/OFBIZ-4290
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Philippe Mouawad
> Assignee: Jacques Le Roux
> Priority: Minor
> Labels: performance
> Fix For: SVN trunk
>
> Attachments: patch-OFBIZ-4290.patch
>
>
> Hello,
> UtilCache#getPropertyParam should call res.containsKey instead of relying on catching MissingResourceException, which will reduce number of Exceptions created so CPU.
> Regards
> Philippe
> http://www.ubik-ingenierie.com
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4290) UtilCache#getPropertyParam should
test property existence instead of rely on MissingResourceException
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037813#comment-13037813 ]
Jacques Le Roux commented on OFBIZ-4290:
----------------------------------------
Ah Philippe,
Something I forgot: please be careful with your indentations, (re-)read https://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions and by and large https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices
See r1126399 for this case
> UtilCache#getPropertyParam should test property existence instead of rely on MissingResourceException
> ------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4290
> URL: https://issues.apache.org/jira/browse/OFBIZ-4290
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Philippe Mouawad
> Assignee: Jacques Le Roux
> Priority: Minor
> Labels: performance
> Fix For: SVN trunk
>
> Attachments: patch-OFBIZ-4290.patch
>
>
> Hello,
> UtilCache#getPropertyParam should call res.containsKey instead of relying on catching MissingResourceException, which will reduce number of Exceptions created so CPU.
> Regards
> Philippe
> http://www.ubik-ingenierie.com
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4290) UtilCache#getPropertyParam should
test property existence instead of rely on MissingResourceException
Posted by "Philippe Mouawad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philippe Mouawad updated OFBIZ-4290:
------------------------------------
Attachment: patch-OFBIZ-4290.patch
The fix
> UtilCache#getPropertyParam should test property existence instead of rely on MissingResourceException
> ------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4290
> URL: https://issues.apache.org/jira/browse/OFBIZ-4290
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Philippe Mouawad
> Priority: Minor
> Labels: performance
> Attachments: patch-OFBIZ-4290.patch
>
>
> Hello,
> UtilCache#getPropertyParam should call res.containsKey instead of relying on catching MissingResourceException, which will reduce number of Exceptions created so CPU.
> Regards
> Philippe
> http://www.ubik-ingenierie.com
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira