You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/10/07 13:28:28 UTC

[GitHub] [calcite] asolimando commented on a diff in pull request #2928: [CALCITE-5306] Support LTS JDKs and latest in testing

asolimando commented on code in PR #2928:
URL: https://github.com/apache/calcite/pull/2928#discussion_r990091096


##########
.github/workflows/main.yml:
##########
@@ -123,7 +123,7 @@ jobs:
 
   linux-openj9:

Review Comment:
   Thanks @michaelmior, I have missed that!
   
   I am afraid the original intent will be hard to tell since it's been introduced by a commit without associated Jira ticket, and the commit message does not mention the target OS: `Add OpenJ9 1.8 CI job at GitHub Actions`.
   
   Looking at the inventory from [CALCITE-5306](https://issues.apache.org/jira/browse/CALCITE-5306) I'd be inclined to use `MacOS` here, since we only have a single job for `JDK18` running there, where all the rest is mostly on `Linux` (which makes sense) and three jobs using `Windows`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org