You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/29 11:09:45 UTC
[GitHub] [incubator-seatunnel] arifgore opened a new pull request, #2951: Modified Spark and Flink starter Dockerfiles
arifgore opened a new pull request, #2951:
URL: https://github.com/apache/incubator-seatunnel/pull/2951
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [X] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] github-actions[bot] commented on pull request #2951: [Improve][Docker]Modified Spark and Flink starter Dockerfiles
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2951:
URL: https://github.com/apache/incubator-seatunnel/pull/2951#issuecomment-1449131155
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] github-actions[bot] closed pull request #2951: [Improve][Docker]Modified Spark and Flink starter Dockerfiles
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2951: [Improve][Docker]Modified Spark and Flink starter Dockerfiles
URL: https://github.com/apache/incubator-seatunnel/pull/2951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] arifgore commented on a diff in pull request #2951: [Improve][Docker]Modified Spark and Flink starter Dockerfiles
Posted by GitBox <gi...@apache.org>.
arifgore commented on code in PR #2951:
URL: https://github.com/apache/incubator-seatunnel/pull/2951#discussion_r995687252
##########
seatunnel-core/seatunnel-flink-starter/src/main/docker/Dockerfile:
##########
@@ -20,18 +20,29 @@ FROM $BASE_IMAGE
ARG SCALA_VERSION
ARG FLINK_VERSION
+ARG SEATUNNEL_VERSION
RUN mkdir -p /flink ; cd /flink ; \
tar_file=flink-${FLINK_VERSION}-bin-scala_${SCALA_VERSION}.tgz ; \
curl -LsO https://archive.apache.org/dist/flink/flink-${FLINK_VERSION}/$tar_file ; \
tar -zxf $tar_file --strip 1 -C . ; \
rm $tar_file
-
+
Review Comment:
I don't get it. What should I revert exactly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] github-actions[bot] commented on pull request #2951: [Improve][Docker]Modified Spark and Flink starter Dockerfiles
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2951:
URL: https://github.com/apache/incubator-seatunnel/pull/2951#issuecomment-1461077279
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2951: [Improve][Docker]Modified Spark and Flink starter Dockerfiles
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2951:
URL: https://github.com/apache/incubator-seatunnel/pull/2951#discussion_r984173318
##########
seatunnel-core/seatunnel-flink-starter/src/main/docker/Dockerfile:
##########
@@ -20,18 +20,29 @@ FROM $BASE_IMAGE
ARG SCALA_VERSION
ARG FLINK_VERSION
+ARG SEATUNNEL_VERSION
RUN mkdir -p /flink ; cd /flink ; \
tar_file=flink-${FLINK_VERSION}-bin-scala_${SCALA_VERSION}.tgz ; \
curl -LsO https://archive.apache.org/dist/flink/flink-${FLINK_VERSION}/$tar_file ; \
tar -zxf $tar_file --strip 1 -C . ; \
rm $tar_file
-
+
Review Comment:
revert？
##########
seatunnel-core/seatunnel-spark-starter/src/main/docker/Dockerfile:
##########
@@ -29,9 +30,14 @@ RUN mkdir -p /spark ; cd /spark ; \
ENV SPARK_HOME=/spark
-WORKDIR /seatunnel
+RUN mkdir /seatunnel ; cd /seatunnel ; \
+ seatunnel_archive_name=apache-seatunnel-incubating-${SEATUNNEL_VERSION}-bin.tar.gz ; \
+ curl -LsO https://archive.apache.org/dist/incubator/seatunnel/${SEATUNNEL_VERSION}/$seatunnel_archive_name ; \
+ tar -zxf $seatunnel_archive_name --strip 1 -C . ; \
+ rm $seatunnel_archive_name; \
+ rm -rf /seatunnel/connectors/flink* /seatunnel/bin/start-seatunnel-{"flink","sql"}.sh /seatunnel/lib/seatunnel-core-flink* /seatunnel/config/seatunnel-env.sh
+
-COPY target/seatunnel-core-spark.jar /seatunnel/lib/
-COPY src/main/bin /seatunnel/bin/
+WORKDIR /seatunnel
ENTRYPOINT [ "/seatunnel/bin/start-seatunnel-spark.sh" ]
Review Comment:
Need to update? same as flink
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2951: [Improve][Docker]Modified Spark and Flink starter Dockerfiles
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2951:
URL: https://github.com/apache/incubator-seatunnel/pull/2951#issuecomment-1272441435
Please resolve conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org