[GitHub] [iceberg] jerryshao commented on a change in pull request #1627: Minor MicroBatch Class Cleanup and Return to Spark Structured Streaming Reader

[GitBox <gi...@apache.org>]

jerryshao commented on a change in pull request #1627:
URL: https://github.com/apache/iceberg/pull/1627#discussion_r511957493



##########
File path: core/src/main/java/org/apache/iceberg/MicroBatches.java
##########
@@ -145,7 +158,7 @@ public MicroBatch generate(int startFileIndex, long targetSizeInBytes, boolean i
     /**
      * Method to skip the manifest file in which the index is smaller than startFileIndex. For example, if the
      * index list is : (m1, 0), (m2, 3), (m3, 5), and startFileIndex is 4, then the returned manifest index list is:
-     * (m2, 3), (m3, 5).
+     * (m3, 5).

Review comment:
       The change is not correct. If the `startFileIndex` is 4, then "(m2, 3)" should not be skipped, the 4th index is included in "(m2, 3)"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org