[GitHub] [pinot] 61yao commented on a diff in pull request #9957: [multistage] [feature] Add a query option to pass some v1 limit

[GitBox <gi...@apache.org>]

61yao commented on code in PR #9957:
URL: https://github.com/apache/pinot/pull/9957#discussion_r1051190574


##########
pinot-core/src/main/java/org/apache/pinot/core/util/QueryOptionsUtils.java:
##########
@@ -105,4 +105,56 @@ public static boolean isServerReturnFinalResult(Map<String, String> queryOptions
   public static String getOrderByAlgorithm(Map<String, String> queryOptions) {
     return queryOptions.get(QueryOptionKey.ORDER_BY_ALGORITHM);
   }
+
+  public static int getMultiStageLeafLimit(Map<String, String> queryOptions, int defaultLeafLimit) {

Review Comment:
   If # of rows scanned exceeds the limit, we may return wrong result right? 
   
   The principle here is set up like limit or cap should be configurable via things other than codes. 
   Cluster config is also good but I guess right now, it would be good to start with an option in query and we eventually move some of them to cluster config if we don't need to change it query by query. 
   
   I admit it is kinda hacky to set everything via query option.. but I don't know a better way to make stuff configurable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org