You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2017/05/01 16:58:35 UTC

[GitHub] spark pull request #17800: [SPARK-20459][SQL] JdbcUtils throws IllegalStateE...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17800#discussion_r114154920
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ---
    @@ -653,7 +653,13 @@ object JdbcUtils extends Logging {
             val cause = e.getNextException
             if (cause != null && e.getCause != cause) {
               if (e.getCause == null) {
    -            e.initCause(cause)
    +            try {
    +              e.initCause(cause)
    +            } catch {
    +              // cause may have been explicitly initialized to null, in which case this
    --- End diff --
    
    @gatorsmile oh are you suggesting the comment is a bit misleading? yeah I can fix that to be clearer about the scenario


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org